Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus scaler "disableScaleToZero" attribute #381

Closed
abhirockzz opened this issue Oct 15, 2019 · 1 comment · Fixed by #392
Closed

Prometheus scaler "disableScaleToZero" attribute #381

abhirockzz opened this issue Oct 15, 2019 · 1 comment · Fixed by #392

Comments

@abhirockzz
Copy link
Contributor

The example for Prometheus ScaledObject includes the disableScaleToZero attribute. I don't see it being used in the metadata definition. Is this valid ?
@balchua
Copy link
Contributor

balchua commented Oct 16, 2019

@abhirockzz, you're right. i dont think its used at all. The sample is obsolete.
Having the minreplicas=1 defined is sufficient.

@abhirockzz abhirockzz mentioned this issue Oct 22, 2019
Merged
@fbalicchia fbalicchia mentioned this issue Aug 22, 2021
Merged
zroubalik pushed a commit that referenced this issue Aug 23, 2021
@fbalicchia
Adapt Prometheus test to #381 (#2051)
fe032cc 
Signed-off-by: fbalicchia <fbalicchia@cuebiq.com>
nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this issue Oct 23, 2021
@fbalicchia @nilayasiktoprak
Adapt Prometheus test to kedacore#381 (kedacore#2051)
27952d1 
Signed-off-by: fbalicchia <fbalicchia@cuebiq.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed 'disableScaleToZero' attribute from Prometheus scaled ob…
2 participants
@abhirockzz @balchua