Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Provide e2e variable for Object ID of Active Directory application & Workload Identity #2947

Merged
merged 2 commits into from
Apr 29, 2022
Merged

feat: Provide e2e variable for Object ID of Active Directory application & Workload Identity #2947

merged 2 commits into from
Apr 29, 2022

Conversation

tomkerkhove
Copy link
Member

@tomkerkhove tomkerkhove commented Apr 28, 2022 •
edited
Loading

Provide e2e variable for Object ID of Active Directory application and rename AZURE_SP_ID to AZURE_SP_APP_ID.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to #2941
Relates to #2895

@tomkerkhove tomkerkhove requested a review from a team as a code owner April 28, 2022 13:04
@tomkerkhove
Copy link
Member Author

tomkerkhove commented Apr 28, 2022 •
edited by github-actions bot
Loading

/run-e2e azure*

Update: You can check the progres here

@tomkerkhove
Copy link
Member Author

tomkerkhove commented Apr 29, 2022 •
edited by github-actions bot
Loading

/run-e2e azure*

Update: You can check the progres here

@JorTurFer
Copy link
Member

JorTurFer commented Apr 29, 2022 •
edited
Loading

Remember that e2e test on PR uses the workflow from main branch, make get-cluster-context use the new variables but the environment variables (set in the yaml file) are still the old because the yaml is not in main yet

@tomkerkhove
Copy link
Member Author

tomkerkhove commented Apr 29, 2022 •
edited by github-actions bot
Loading

/run-e2e azure*

Update: You can check the progres here

@tomkerkhove
Copy link
Member Author

tomkerkhove commented Apr 29, 2022 •
edited by github-actions bot
Loading

/run-e2e azure*

Update: You can check the progres here

@tomkerkhove
feat: Provide e2e variable for Object ID of Active Directory application
95e71e2 
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@tomkerkhove tomkerkhove changed the title feat: Provide e2e variable for Object ID of Active Directory application feat: Provide e2e variable for Object ID of Active Directory application & Workload Identity Apr 29, 2022
@tomkerkhove
OIDC_ISSUER_URL -> OIDC_ISSUER_URL
8a108aa 
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@JorTurFer JorTurFer merged commit f32eec0 into kedacore:main Apr 29, 2022
bamboo12366 pushed a commit to bamboo12366/keda that referenced this pull request Apr 30, 2022
@tomkerkhove @bamboo12366
feat: Provide e2e variable for Object ID of Active Directory applicat…
09173c4 
…ion & Workload Identity (kedacore#2947)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomkerkhove @JorTurFer