Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add needed resources in the clusters for e2e test with AAD-Workload-identity #2941

Closed
v-shenoy opened this issue Apr 27, 2022 · 3 comments
Closed

Add needed resources in the clusters for e2e test with AAD-Workload-identity #2941

v-shenoy opened this issue Apr 27, 2022 · 3 comments
Assignees
@tomkerkhove @v-shenoy
Labels
auth azure All issues concerning integration with Azure enhancement New feature or request testing

Comments

@v-shenoy
Copy link
Contributor

v-shenoy commented Apr 27, 2022 •
edited
Loading

Proposal

Azure AD Workload Identity support is currently in process of being added. With this in mind, we should have e2e tests covering this scenario. Preferably for all Azure scalers, but at least one to ensure that the changes do not break this feature.

Creating this issue for tracking purposes.

Use-Case
Improve the trust in the e2e test because they cover more scenarios

Anything else?
Relates to #2487, #2907
@v-shenoy v-shenoy added enhancement New feature or request auth azure All issues concerning integration with Azure testing labels Apr 27, 2022
@v-shenoy v-shenoy mentioned this issue Apr 27, 2022
Merged
5 tasks
@tomkerkhove tomkerkhove mentioned this issue Apr 29, 2022
Merged
1 task
@JorTurFer JorTurFer mentioned this issue Apr 29, 2022
Merged
1 task
@tomkerkhove
Copy link
Member

Do we need to add anything else?

@v-shenoy
Copy link
Contributor Author

v-shenoy commented May 9, 2022

Do we need to add anything else?

The tests are passing, so we have everything. Let's just keep this open until the main PR is merged.

@tomkerkhove
Copy link
Member

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomkerkhove tomkerkhove

@v-shenoy v-shenoy

Labels
auth azure All issues concerning integration with Azure enhancement New feature or request testing
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomkerkhove @v-shenoy