-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded Azure Pipelines to support demands #2795
Conversation
Signed-off-by: mortx <mortxbox@live.com>
@JorTurFer would you mind reviewing this one when you have time? It's been open for a while |
I'm waiting your opinions is docs |
@Eldarrin Any thought if we can close this PR soon? We are planning to release in 2 weeks. |
@tomkerkhove Its all fine and ready to be merged I believe. I'm actually running it in production at my client's organisation. |
Nice to hear! But we should probably move to the approach proposed by @JorTurFer if that's OK for you? |
Ok, let me have a look. Want me to take a new fork and start from there? |
I don't have a problem if you want to update this PR, but it's up to what you prefer. We can have both approaches in parallel to compare as well if you want. |
Signed-off-by: mortx <mortxbox@live.com>
Signed-off-by: mortx <mortxbox@live.com>
Now support demands and parent metadata, tested it on my clusters as working; added docs to support |
Thank you @JorTurFer Do you want to have a look? |
/run-e2e pipeline |
I understand the "parent" approach, but requiring an already deployed deployment only for registering the job looks like overkill. Nothing to add to the code itself, but I think that we need to solve the approach for that in the docs repo. |
Signed-off-by: mortx <mortxbox@live.com>
Signed-off-by: mortx <mortxbox@live.com>
@Eldarrin |
There is a code linting issue, could you solve it please? |
Signed-off-by: mortx <mortxbox@live.com>
/run-e2e pipelines* |
@JorTurFer @v-shenoy @tomkerkhove what is the status of this? |
This PR is ready but we are waiting till some things are solved in docs |
Signed-off-by: mortx <mortxbox@live.com>
Signed-off-by: mortx mortxbox@live.com
Old PR: #2707
You can now supply a master template to support demands. NOTE: You must have a master supporting agent even if it is offline!
Checklist
Relates to kedacore/keda-docs#685
Relates to #2328