Added documentation for Azure Pipelines Demands #685

Eldarrin · 2022-03-02T16:26:35Z

Documents using parents to support demands in ADO

Checklist

Commits are signed with Developer Certificate of Origin (DCO)

Relates to kedacore/keda#2328
Relates to kedacore/keda#2795

netlify · 2022-03-02T16:26:41Z

✅ Deploy Preview for keda ready!

Name	Link
🔨 Latest commit	`f058b42`
🔍 Latest deploy log	https://app.netlify.com/sites/keda/deploys/62e9423d1f64f50008ad267e
😎 Deploy Preview	https://deploy-preview-685--keda.netlify.app/docs/2.8/scalers/azure-pipelines
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

content/docs/2.7/scalers/azure-pipelines.md

tomkerkhove

Made some editorial suggestions to make it easier to read and remove the direct references to ScaledJob since you can also use it with ScaledObject

content/docs/2.8/scalers/azure-pipelines.md

tomkerkhove · 2022-07-13T13:28:57Z

content/docs/2.8/scalers/azure-pipelines.md

+
+#### How it works under the hood.
+
+Azure Devops has a Job Request API with returns a list of all agents which can potentially match up to the Queued Job. KEDA will scan this request to find any matching template from the defined parent in the ScaledJob definition. Once it finds it, it will spin up a ScaledJob that matched the definition and Azure DevOps will assign to that agent.


Can we add a link to the API?

This is a bit of aa weird one. I'm using the same API that keda has always used, but this API is actually not disclosed by Microsoft. There API stops at /pool/id; there is a deeper internal API which is /pool/id/JobRequests. This is undocumented on the MS site I believe; hence as I can't publish an official link, should be left out.

content/docs/2.8/scalers/azure-pipelines.md

JorTurFer · 2022-07-14T09:54:17Z

content/docs/2.8/scalers/azure-pipelines.md

    authenticationRef:
     name: pipeline-trigger-auth
 ```
+###Example for Parent Deployment or StatefulSet


I'm not sure about having the requirement of an agent for doing nothing TBH. I prefer to register the agent manually in the AzDO UI than creating a deployment only for that.
WDYT @kedacore/keda-contributors ?

The reason I use a deployment and then delete it after it has registered in ADO using my CD pipelines is that I can change versions of packages, do upgrades so the capabilities of the agent do change over time. Maintaining a large number of different agents in my build farm works this way. I see no reason why you couldn't do either way though.

Maybe a podspec would be better?

My concern is that you have your own business logic to manage this and it works with your use case, but it's managed by your side, not by KEDA. IMO, we should be most agnostics as possible and use the upstream tools for doing the upstream things. Obviously, we can add a "tip" suggesting the approach, having to deploy (and potentially delete) the deployment only to upgrade the agent in AzDO could be a complex action if you only have 2-3 different agents.

Maybe I'm overthinking about this and that's why I'd like to get the opinion of other @kedacore/keda-contributors but it's more a thing about how we document the feature than an issue with the feature itself (In fact, it's already approved :) ).

JorTurFer · 2022-07-29T08:53:10Z

@Eldarrin
We plan to do a release next week, do you think that you can address this comments before it?

Eldarrin · 2022-07-29T09:29:13Z

@JorTurFer Conversation 1, I can resolve if your happy that that the API is undocumented on the MS side. Conversation 2, I thought you were waiting for comments from other contributors? But can resolve

JorTurFer · 2022-08-02T15:00:31Z

Let's solve the first point, and we can open another issue to improve this in the future, but at least next release will have this feature

JorTurFer · 2022-08-02T15:01:03Z

Please, solve also the signing issue in your commits 🙏

Signed-off-by: mortx <mortxbox@live.com>

Signed-off-by: Patrice Chalin <pchalin@gmail.com> Signed-off-by: mortx <mortxbox@live.com>

Signed-off-by: mortx <mortxbox@live.com>

) Signed-off-by: mortx <mortxbox@live.com>

…#815) Signed-off-by: mortx <mortxbox@live.com>

…er (#811) Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: mortx <mortxbox@live.com>

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: mortx <mortxbox@live.com>

) Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: mortx <mortxbox@live.com>

…812) Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: mortx <mortxbox@live.com>

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: mortx <mortxbox@live.com>

Signed-off-by: Jonas Bentz <Jonas-Bentz@gmx.de> Signed-off-by: mortx <mortxbox@live.com>

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: mortx <mortxbox@live.com>

…824) Signed-off-by: mortx <mortxbox@live.com>

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: mortx <mortxbox@live.com>

…aler (#823) Signed-off-by: mortx <mortxbox@live.com>

Signed-off-by: mortx <mortxbox@live.com>

…#826) Signed-off-by: mortx <mortxbox@live.com>

Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com> Signed-off-by: mortx <mortxbox@live.com>

…kload Scaler (#828) Signed-off-by: mortx <mortxbox@live.com>

…enstack metrics Scalers (#829) Signed-off-by: mortx <mortxbox@live.com>

Signed-off-by: mortx <mortxbox@live.com>

) * feat: Introduce activationThreshold/minMetricValue for GCP scalers Signed-off-by: Ram Cohen <ram.cohen@gmail.com> * Fixes Signed-off-by: Ram Cohen <ram.cohen@gmail.com> Signed-off-by: mortx <mortxbox@live.com>

…835) Signed-off-by: mortx <mortxbox@live.com>

…834) Signed-off-by: mortx <mortxbox@live.com>

#838) Signed-off-by: mortx <mortxbox@live.com>

#843) Signed-off-by: mortx <mortxbox@live.com>

…t Scaler (#841) Signed-off-by: mortx <mortxbox@live.com>

Eldarrin · 2022-08-02T15:29:20Z

.... abandon pr and start over? followed the instructions to rebase and it blew up

JorTurFer · 2022-08-02T16:08:29Z

.... abandon pr and start over? followed the instructions to rebase and it blew up

Maybe squashing the branch, you could solve it. If not, feel free to close this and open another

Eldarrin · 2022-08-03T10:26:05Z

Closing to re-add just azure_pipelines.md as new PR

Eldarrin requested review from jeffhollan, ahmelsayed, tomkerkhove, zroubalik and JorTurFer as code owners March 2, 2022 16:26

tomkerkhove mentioned this pull request Mar 3, 2022

Added a demand checker for Azure Pipelines kedacore/keda#2707

Closed

5 tasks

tomkerkhove reviewed Mar 3, 2022

View reviewed changes

content/docs/2.7/scalers/azure-pipelines.md Outdated Show resolved Hide resolved

zroubalik mentioned this pull request Mar 25, 2022

Enable support for non-public clouds in Application Insights scaler. kedacore/keda#2818

Merged

5 tasks

tomkerkhove mentioned this pull request Jul 13, 2022

Upgraded Azure Pipelines to support demands kedacore/keda#2795

Merged

5 tasks

tomkerkhove suggested changes Jul 13, 2022

View reviewed changes

JorTurFer reviewed Jul 14, 2022

View reviewed changes

JorTurFer requested a review from tomkerkhove July 29, 2022 11:01

Eldarrin and others added 13 commits August 2, 2022 16:21

Added documentation for Azure Pipelines Demands

09f37b5

Signed-off-by: mortx <mortxbox@live.com>

Updated Demand Works explanation

2db6c63

Signed-off-by: mortx <mortxbox@live.com>

Clarify datadog rate limit (#682)

af5033a

Signed-off-by: mortx <mortxbox@live.com>

Fix some broken anchors (#689)

92485ec

Signed-off-by: mortx <mortxbox@live.com>

Netlify CLI: add framework flag (#690)

89a8466

Signed-off-by: mortx <mortxbox@live.com>

Update link checking scripts / targets (#696)

a310348

Signed-off-by: mortx <mortxbox@live.com>

Upgrade Hugo to 0.93.2 (#695)

990c4a8

Signed-off-by: mortx <mortxbox@live.com>

Add Stilingue as KEDA user (#688)

6c7785e

Signed-off-by: mortx <mortxbox@live.com>

Layout cleanup in preparation of title format change (#691)

2afd468

Signed-off-by: mortx <mortxbox@live.com>

docs: Provide guidance on how CRON scaler works (#698)

7c37064

Signed-off-by: mortx <mortxbox@live.com>

Drop prebuild placeholder and associated scripts (#699)

e0884c9

Signed-off-by: mortx <mortxbox@live.com>

Make HTML titles consistent: "<page-title> | KEDA" (#700)

8869fd2

Signed-off-by: mortx <mortxbox@live.com>

Remove make targets using non npx-hugo, adjust Netlify config (#701)

bba5bcf

Signed-off-by: Patrice Chalin <pchalin@gmail.com> Signed-off-by: mortx <mortxbox@live.com>

Eldarrin and others added 25 commits August 2, 2022 16:26

Changed ScaledJob to ScaledObject (#685)

4c7f4b7

Signed-off-by: mortx <mortxbox@live.com>

feat: Introduce activationThreshold/minMetricValue for AWS Scalers (#808

f2ec144

) Signed-off-by: mortx <mortxbox@live.com>

feat: Introduce activationThreshold/minMetricValue for Elastic Scaler (…

3048ec7

…#815) Signed-off-by: mortx <mortxbox@live.com>

feat: Introduce activationThreshold/minMetricValue for Cassandra Scal…

690a290

…er (#811) Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: mortx <mortxbox@live.com>

feat: introduce activationThreshold for Graphite Scaler (#817)

af986cb

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: mortx <mortxbox@live.com>

feat: Introduce activationTargetQueryValue for PostgreSQL Scaler (#820

ec83366

) Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: mortx <mortxbox@live.com>

feat: Introduce activationThreshold/minMetricValue for Datado Scaler (#…

262b58f

…812) Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: mortx <mortxbox@live.com>

feat: Introduce activationLagThreshold for Stan Scaler (#821)

4fd0856

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: mortx <mortxbox@live.com>

Update scaling-jobs.md (#804)

ba26c0e

Signed-off-by: Jonas Bentz <Jonas-Bentz@gmx.de> Signed-off-by: mortx <mortxbox@live.com>

feat: Introduce activationTargetValue for MS SQL Scaler (#822)

b5c0335

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: mortx <mortxbox@live.com>

feat: Introduce activationThreshold/minMetricValue for Huawei Scaler (#…

d24bb19

…824) Signed-off-by: mortx <mortxbox@live.com>

feat: Introduce activationThreshold for Prometheus Scaler (#827)

3f3b5bd

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: mortx <mortxbox@live.com>

feat: Introduce activationThreshold/minMetricValue for Metrics API Sc…

b4064b1

…aler (#823) Signed-off-by: mortx <mortxbox@live.com>

feat: Introduce activationThreshold/minMetricValue for IBM Scaler (#825)

9ff3d86

Signed-off-by: mortx <mortxbox@live.com>

feat: Introduce activationThreshold/minMetricValue for MongoDB Scaler (…

e9eccc4

…#826) Signed-off-by: mortx <mortxbox@live.com>

fix: expand readOnlyRootFilesystem answer (#830)

b528f5a

Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com> Signed-off-by: mortx <mortxbox@live.com>

feat: Introduce activationThreshold/minMetricValue for Kubernetes Wor…

7de2bd3

…kload Scaler (#828) Signed-off-by: mortx <mortxbox@live.com>

feat: Introduce activationThreshold/minMetricValue for Liiklus and Op…

503d6f9

…enstack metrics Scalers (#829) Signed-off-by: mortx <mortxbox@live.com>

chore: fix typo on liiklus scaler (#833)

5417040

Signed-off-by: mortx <mortxbox@live.com>

feat: Introduce activationThreshold/minMetricValue for GCP scalers (#831

a7008d0

) * feat: Introduce activationThreshold/minMetricValue for GCP scalers Signed-off-by: Ram Cohen <ram.cohen@gmail.com> * Fixes Signed-off-by: Ram Cohen <ram.cohen@gmail.com> Signed-off-by: mortx <mortxbox@live.com>

feat: Introduce activationThreshold/minMetricValue for MySQL Scaler (#…

a1a5a08

…835) Signed-off-by: mortx <mortxbox@live.com>

feat: Introduce activationThreshold/minMetricValue for Solace Scaler (#…

eb00ff8

…834) Signed-off-by: mortx <mortxbox@live.com>

feat: Introduce activationThreshold/minMetricValue for Predictkube Sc… (

edb0944

#838) Signed-off-by: mortx <mortxbox@live.com>

feat: Introduce activationThreshold/minMetricValue for Selenium Scaler (

1ad9439

#843) Signed-off-by: mortx <mortxbox@live.com>

feat: Introduce activationThreshold/minMetricValue for Openstack Swif…

f058b42

…t Scaler (#841) Signed-off-by: mortx <mortxbox@live.com>

Eldarrin closed this Aug 3, 2022

Eldarrin mentioned this pull request Aug 3, 2022

feat: Added demand functionality to ADO pipelines #862

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added documentation for Azure Pipelines Demands #685

Added documentation for Azure Pipelines Demands #685

Eldarrin commented Mar 2, 2022 •

edited by tomkerkhove

Loading

netlify bot commented Mar 2, 2022 •

edited

Loading

tomkerkhove left a comment

tomkerkhove Jul 13, 2022

Eldarrin Jul 13, 2022 •

edited

Loading

JorTurFer Jul 14, 2022

Eldarrin Jul 14, 2022 •

edited

Loading

JorTurFer Jul 14, 2022

JorTurFer commented Jul 29, 2022

Eldarrin commented Jul 29, 2022

JorTurFer commented Aug 2, 2022

JorTurFer commented Aug 2, 2022

Eldarrin commented Aug 2, 2022 •

edited

Loading

JorTurFer commented Aug 2, 2022

Eldarrin commented Aug 3, 2022


		#### How it works under the hood.

		Azure Devops has a Job Request API with returns a list of all agents which can potentially match up to the Queued Job. KEDA will scan this request to find any matching template from the defined parent in the ScaledJob definition. Once it finds it, it will spin up a ScaledJob that matched the definition and Azure DevOps will assign to that agent.

Added documentation for Azure Pipelines Demands #685

Added documentation for Azure Pipelines Demands #685

Conversation

Eldarrin commented Mar 2, 2022 • edited by tomkerkhove Loading

Checklist

netlify bot commented Mar 2, 2022 • edited Loading

✅ Deploy Preview for keda ready!

tomkerkhove left a comment

Choose a reason for hiding this comment

tomkerkhove Jul 13, 2022

Choose a reason for hiding this comment

Eldarrin Jul 13, 2022 • edited Loading

Choose a reason for hiding this comment

JorTurFer Jul 14, 2022

Choose a reason for hiding this comment

Eldarrin Jul 14, 2022 • edited Loading

Choose a reason for hiding this comment

JorTurFer Jul 14, 2022

Choose a reason for hiding this comment

JorTurFer commented Jul 29, 2022

Eldarrin commented Jul 29, 2022

JorTurFer commented Aug 2, 2022

JorTurFer commented Aug 2, 2022

Eldarrin commented Aug 2, 2022 • edited Loading

JorTurFer commented Aug 2, 2022

Eldarrin commented Aug 3, 2022

Eldarrin commented Mar 2, 2022 •

edited by tomkerkhove

Loading

netlify bot commented Mar 2, 2022 •

edited

Loading

Eldarrin Jul 13, 2022 •

edited

Loading

Eldarrin Jul 14, 2022 •

edited

Loading

Eldarrin commented Aug 2, 2022 •

edited

Loading