Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCP Pub/Sub Scaler: add logic to accept subscription IDs with projectID #2269

Merged
merged 13 commits into from
Nov 23, 2021
Merged

GCP Pub/Sub Scaler: add logic to accept subscription IDs with projectID #2269

merged 13 commits into from
Nov 23, 2021

Commits on Nov 10, 2021

  1. Add logic to accept subscription IDs identifying the whole chain, inc… 

    …luding projectID

Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
    Jose Maria Alvarez committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    c21db94 View commit details
    Browse the repository at this point in the history

  2. Correct static checks 

    Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
    Jose Maria Alvarez committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    34ba675 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2021

  1. Update pkg/scalers/gcp_pub_sub_scaler.go 

    Co-authored-by: Herman <hermanbanken@gmail.com>
Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
    @jmalvarezf-lmes @hermanbanken
    2 people authored and Jose Maria Alvarez committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    c2e1e25 View commit details
    Browse the repository at this point in the history

  2. Avoid unneccessary logic 

    Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
    Jose Maria Alvarez committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    51f83f9 View commit details
    Browse the repository at this point in the history

  3. Correct regular expression 

    Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
    Jose Maria Alvarez committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    bee53c7 View commit details
    Browse the repository at this point in the history

  4. Add private method to get subscription data from subscription string 

    Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
    Jose Maria Alvarez committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    376dfbc View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Add tests to check regexp expression 

    Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
    Jose Maria Alvarez committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    443c22e View commit details
    Browse the repository at this point in the history

  2. Add functionality in improvements 

    Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
    Jose Maria Alvarez committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    a04f3c0 View commit details
    Browse the repository at this point in the history

  3. Correct PR number 

    Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
    Jose Maria Alvarez committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    a336618 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feature/pubsub-other-project

    @jmalvarezf-lmes
    jmalvarezf-lmes authored Nov 17, 2021
    Configuration menu
    Copy the full SHA
    b72821a View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. Merge branch 'main' into feature/pubsub-other-project

    @jmalvarezf-lmes
    jmalvarezf-lmes authored Nov 23, 2021
    Configuration menu
    Copy the full SHA
    a42c2b8 View commit details
    Browse the repository at this point in the history

  2. Correct indentation and unused var 

    Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
    Jose Maria Alvarez committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    ab61f1d View commit details
    Browse the repository at this point in the history

  3. Correct indexes for testing 

    Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
    Jose Maria Alvarez committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    0712847 View commit details
    Browse the repository at this point in the history