GCP Pub/Sub Scaler: add logic to accept subscription IDs with projectID #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…luding projectID Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
jmalvarezf-lmes
requested review from
ahmelsayed and
zroubalik
as code owners
Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
jmalvarezf-lmes
force-pushed
the
feature/pubsub-other-project
branch
from
66511aa
to
34ba675
Compare
|
I am not GCP expert, @hermanbanken @Friedrich42 WDYT? |
zroubalik
changed the title
Co-authored-by: Herman <hermanbanken@gmail.com> Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
jmalvarezf-lmes
force-pushed
the
feature/pubsub-other-project
branch
from
95ab872
to
c2e1e25
Compare
added 2 commits
November 12, 2021 14:19
Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
fira42073
reviewed
Nov 12, 2021
Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
|
@jmalvarezf-lmes do you think you can open docs PR and update the changelog? |
|
@jmalvarezf-lmes And could you please add some tests? We should test the regex, parsing of the new field and even the functionality if possible. |
Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
|
Hi @zroubalik, I've added a test for the regexp, and updated the docs. Let me know if you think they are fine. Thanks! |
|
The PR for the docs: kedacore/keda-docs#585 |
|
@jmalvarezf-lmes the PR looks good, so to merge this, could you please resolve the conflicts that were caused by merging #2266 Thanks! |
Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
|
Hi @zroubalik, Done. Regards, |
zroubalik
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR should address #2256. Basically, you can provide a subscriptionID with the form of "projects/[a-zA-Z0-9-]+/subscriptions/[a-zA-Z0-9-]+" instead of only the name, so that you are able to use the project ID specified in the chain to know where the subscription is, and not only use the project of the credentials, or the underlying project associated with the infrastructure.
Please, let me know if this helps. Also, if this is suitable, I will update the docs before merging.
Thanks!
Jose Maria.