Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add file.rmdir #1289

Closed
wants to merge 33 commits into from
Closed

feat: add file.rmdir #1289

wants to merge 33 commits into from

Conversation

JeevaRamanathan
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kcl-lang/kcl/kclvm

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@JeevaRamanathan
Copy link
Contributor Author

@Peefy is there a way to sign-off specific commit added file rmdir [725901e], due to which dco is failing.

@Peefy
Copy link
Contributor

Peefy commented May 7, 2024

@Peefy is there a way to sign-off specific commit added file rmdir [725901e], due to which dco is failing.

See https://github.com/kcl-lang/kcl/pull/1289/checks?check_run_id=24665928148

@Peefy
Copy link
Contributor

Peefy commented May 7, 2024

The CI failed and please rebase the main branch.

metacoma and others added 23 commits May 7, 2024 16:01
@metacoma @JeevaRamanathan
Kcl argocd zombie workaround (kcl-lang#1264)
f4fc63c 
* Bump ubuntu base image to 22.04 version

Fix url for python release archive
Fix package name for python3 development files

Fixes kcl-lang#1234

* Add docker image for kcl-cmp plugin with tini utility

Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@Peefy @JeevaRamanathan
docs: update tool integration link and multi SDKs description in read…
57ac898 
…me (kcl-lang#1270)

Signed-off-by: peefy <xpf6677@163.com>
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@Gmin2 @JeevaRamanathan
get_schema_type function will now return SchemaType instances wit…
12fd4b8 
…h base schema information included (kcl-lang#1272)

* `get_schema_type` and `get_full_schema_type` will now return `SchemaType` instance

Signed-off-by: utnim2 <mintugogoi567@gmail.com>

* added  the recursive function

Signed-off-by: utnim2 <mintugogoi567@gmail.com>

* fixed the types

Signed-off-by: utnim2 <mintugogoi567@gmail.com>

---------

Signed-off-by: utnim2 <mintugogoi567@gmail.com>
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@shruti2522 @JeevaRamanathan
feat: add file.mkdir and file.delete functions (kcl-lang#1271)
14f9f44 
* feat: added mkdir and delete module functions

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

corrected formatting

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

updated formatting

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

feat: added mkdir and delete module functions

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

updated linker.rs

feat: added mkdir and delete module functions

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

format checking

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

`get_schema_type` function will now return `SchemaType` instances with base schema information included (kcl-lang#1272)

* `get_schema_type` and `get_full_schema_type` will now return `SchemaType` instance

Signed-off-by: utnim2 <mintugogoi567@gmail.com>

* added  the recursive function

Signed-off-by: utnim2 <mintugogoi567@gmail.com>

* fixed the types

Signed-off-by: utnim2 <mintugogoi567@gmail.com>

---------

Signed-off-by: utnim2 <mintugogoi567@gmail.com>

feat: extend file module functions mkdir and delete

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

feat: added mkdir and delete module functions

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

tests added

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

tests updated

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

feat: added mkdir and delete module functions

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

updated test cases

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

updated kclvm loader snaps

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

added stderr output

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

feat: added mkdir and delete module functions

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

* updated stdout

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

---------

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@Peefy @JeevaRamanathan
feat: enhance the schema expr type check and impl the schema factory …
964a23d 
…using the dynamic type (kcl-lang#1269)

Signed-off-by: peefy <xpf6677@163.com>
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@Peefy @JeevaRamanathan
fix: file.mkdir and yaml.decode_all functions and bump version to v0.…
da85c91 
…8.7 (kcl-lang#1276)

Signed-off-by: peefy <xpf6677@163.com>
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@zong-zhe @JeevaRamanathan
feat: add type name for schema_expr in list_variables (kcl-lang#1279)
b310b81 
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@Peefy @JeevaRamanathan
chore: polish copyright (kcl-lang#1278)
9cd889b 
Signed-off-by: peefy <xpf6677@163.com>
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@shruti2522 @JeevaRamanathan
feat: add file.cp and file.mv functions (kcl-lang#1277)
5fbfe1a 
* feat: add file.cp and file.mv functions

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

* fix ci error

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

* fix ci

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

---------

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@Peefy @JeevaRamanathan
ci: add macos14 and evluator tests (kcl-lang#1280)
7d0f54e 
* ci: add macos14 and evluator tests

Signed-off-by: peefy <xpf6677@163.com>

* chore: remove un-used docker images

Signed-off-by: peefy <xpf6677@163.com>

---------

Signed-off-by: peefy <xpf6677@163.com>
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@Peefy @JeevaRamanathan
feat: add file folder cp (kcl-lang#1281)
768f13a 
Signed-off-by: peefy <xpf6677@163.com>
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@zong-zhe @JeevaRamanathan
feat: add operation for variable in ListVariables (kcl-lang#1282)
78d7204 
* feat: add operation for variable in ListVariables

Signed-off-by: zongz <zongzhe1024@163.com>

* fix: fix test case

Signed-off-by: zongz <zongzhe1024@163.com>

---------

Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@Peefy @JeevaRamanathan
feat: top level variable back reference infra (kcl-lang#1284)
98423e6 
Signed-off-by: peefy <xpf6677@163.com>
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@JeevaRamanathan
feat: add file.size (kcl-lang#1286)
5c4c212 
* initial commit

Signed-off-by: JeevaRamanathan <64531160+JeevaRamanathan@users.noreply.github.com>

* updation on kclvm.h

Signed-off-by: JeevaRamanathan <64531160+JeevaRamanathan@users.noreply.github.com>

* added test

Signed-off-by: JeevaRamanathan <64531160+JeevaRamanathan@users.noreply.github.com>

* config username-email

Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>

* changed type and added stdout.golden

Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>

* updated tests

Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>

---------

Signed-off-by: JeevaRamanathan <64531160+JeevaRamanathan@users.noreply.github.com>
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@Peefy @JeevaRamanathan
chore: update file.size runtime impl and update test cases (kcl-lang#…
5ae2907 
…1287)

Signed-off-by: peefy <xpf6677@163.com>
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@JeevaRamanathan
added file rmdir
98fee40 
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@JeevaRamanathan
wording fix
7f0f2f8 
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@JeevaRamanathan
dco check
d4f50fc 
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@JeevaRamanathan
resolve dco
7e8962a 
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@JeevaRamanathan
resolving dco
868718d 
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@JeevaRamanathan
resolving dco
b7f4b93 
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@JeevaRamanathan
resolving dco
e52698b 
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@JeevaRamanathan
signed
5a7f513 
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@JeevaRamanathan
removed stdout.golden
f4107db 
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@JeevaRamanathan
resolving dco
3619b2b 
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@JeevaRamanathan
dco check
e655762 
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@JeevaRamanathan
resolving dco
baf1677 
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@JeevaRamanathan
resolving dco
e7f42a8 
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@JeevaRamanathan
resolving dco
37d69fe 
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@JeevaRamanathan
signed
49d53ef 
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@JeevaRamanathan
resolving dco
774819f 
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@Peefy
Copy link
Contributor

Peefy commented May 7, 2024 •
edited
Loading

The CI failed and please rebase the main branch and squash the commit or open a new PR with only one commit.
image

@Peefy
Copy link
Contributor

Peefy commented May 7, 2024 •
edited
Loading

It should be noted that this implementation conflicts with the existing implementation file.delete function, so I will close this PR. https://www.kcl-lang.io/docs/reference/model/file#delete

@Peefy Peefy closed this May 7, 2024
@JeevaRamanathan JeevaRamanathan deleted the rmdir branch May 7, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peefy Peefy Peefy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend file module functions (for smoother GitOps)
6 participants
@JeevaRamanathan @Peefy @metacoma @Gmin2 @shruti2522 @zong-zhe