feat: add file.size #1286
Merged
feat: add file.size #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JeevaRamanathan <64531160+JeevaRamanathan@users.noreply.github.com>
Signed-off-by: JeevaRamanathan <64531160+JeevaRamanathan@users.noreply.github.com>
Signed-off-by: JeevaRamanathan <64531160+JeevaRamanathan@users.noreply.github.com>
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Peefy
reviewed
May 6, 2024
|
Hello @JeevaRamanathan Thanks for the contribution. You can ref here to update tests. #1277 |
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
Peefy
added a commit
to kcl-lang/cla.db
that referenced
this pull request
May 6, 2024
|
Hi @Peefy I have updated the tests and added stdout.golden, Could you please review |
JeevaRamanathan
added a commit
to JeevaRamanathan/kcl
that referenced
this pull request
May 7, 2024
* initial commit Signed-off-by: JeevaRamanathan <64531160+JeevaRamanathan@users.noreply.github.com> * updation on kclvm.h Signed-off-by: JeevaRamanathan <64531160+JeevaRamanathan@users.noreply.github.com> * added test Signed-off-by: JeevaRamanathan <64531160+JeevaRamanathan@users.noreply.github.com> * config username-email Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com> * changed type and added stdout.golden Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com> * updated tests Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com> --------- Signed-off-by: JeevaRamanathan <64531160+JeevaRamanathan@users.noreply.github.com> Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
JeevaRamanathan
added a commit
to JeevaRamanathan/kcl
that referenced
this pull request
May 7, 2024
* initial commit Signed-off-by: JeevaRamanathan <64531160+JeevaRamanathan@users.noreply.github.com> * updation on kclvm.h Signed-off-by: JeevaRamanathan <64531160+JeevaRamanathan@users.noreply.github.com> * added test Signed-off-by: JeevaRamanathan <64531160+JeevaRamanathan@users.noreply.github.com> * config username-email Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com> * changed type and added stdout.golden Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com> * updated tests Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com> --------- Signed-off-by: JeevaRamanathan <64531160+JeevaRamanathan@users.noreply.github.com> Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
Fixes Extend file module functions (for smoother GitOps) #1267
2. What is the scope of this PR (e.g. component or file name):
kcl-lang/kcl/kclvm
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
I would like to know are the .snap files are autogenerated or am I missing anything. Please guide