Implement support for now stable rename_dependency feature. Fixes #133. #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoschwarz
commented
Jan 27, 2019
| let name = match t.get("package") { | ||
| Some(&Value::String(ref s)) => s, | ||
| // TODO: Probably this should emit an error? | ||
| Some(_) => &dep_key, |
There was a problem hiding this comment.
As far as I understand "package" for a dependency if present can only be a string indicating the name of the real crates.io package. Right now a "package" value which is not a string is silently ignored, but maybe I should turn that into an error too?
There was a problem hiding this comment.
Cargo rejects non-strings here, so it'd be OK to reject them too.
|
Works for me thanks! Fixes #133 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor patch, but with a project of mine I still experience an error (version conflict) so I'm not certain if it really fixes the issue yet. I'll have to investigate that further.