#30 RepositoryFilter to allow metrics collection #194
Conversation
new RepositoryFilter interface introduced that sits in the repository layer and allows to intercept request, respones and links/meta information gathering. - repository adapters modified to invoke filters - filters get a chain class to decide whether to proceed with the request or return a result on its own. - RepositoryRequestSpec to specify the contents of a request - existing Filter interface should be renamed to make clear that they operate on a different layer (transport vs repository). - Module api extended to allow RepositoryFilter registration - minor refactoring to ResourceRegistry/ModuleRegistry dependency to allow access to RepositoryFilter
- unused imports - fixed a invalid package name (for non-public one)
| } | ||
|
|
||
| @SuppressWarnings({ "unchecked", "rawtypes" }) | ||
| private LinksInformation doGetLinksInformation(Object repository, Iterable<?> resources, RepositoryRequestSpec requestSpec) { |
There was a problem hiding this comment.
Move this method into "RepositoryLinksFilterChainImpl". 
| } | ||
|
|
||
| @SuppressWarnings({ "unchecked", "rawtypes" }) | ||
| private MetaInformation doGetMetaInformation(Object repository, Iterable<?> resources, RepositoryRequestSpec requestSpec) { |
There was a problem hiding this comment.
Move this method into "RepositoryMetaFilterChainImpl".
|
|
||
| import io.katharsis.module.ModuleRegistry; | ||
| import io.katharsis.queryParams.QueryParams; | ||
| import io.katharsis.queryspec.DefaultQuerySpecConverter; |
There was a problem hiding this comment.
Remove this unused import 'io.katharsis.queryspec.DefaultQuerySpecConverter'.
| } | ||
| } | ||
|
|
||
| private <T> String toUrl(QueryAdapter queryAdapter, PagedResultList<T> pagedResultList, RepositoryRequestSpec requestSpec) { |
There was a problem hiding this comment.
Remove this unused method parameter "pagedResultList".
| import io.katharsis.module.ModuleRegistry; | ||
| import io.katharsis.queryParams.QueryParams; | ||
| import io.katharsis.queryspec.DefaultQuerySpecConverter; | ||
| import io.katharsis.queryspec.QuerySpec; |
There was a problem hiding this comment.
Remove this unused import 'io.katharsis.queryspec.QuerySpec'.
| } | ||
|
|
||
| private <S extends T> JsonApiResponse save(S entity, QueryAdapter queryAdapter, HttpMethod method) { | ||
| RepositoryRequestFilterChainImpl chain = new RepositoryRequestFilterChainImpl() { |
There was a problem hiding this comment.
Reduce this anonymous class number of lines from 22 to at most 20, or make it a named class.
| } | ||
|
|
||
| public JsonApiResponse findOne(I id, QueryAdapter queryAdapter) { | ||
| RepositoryRequestFilterChainImpl chain = new RepositoryRequestFilterChainImpl() { |
There was a problem hiding this comment.
Reduce this anonymous class number of lines from 23 to at most 20, or make it a named class.
| } | ||
|
|
||
| public JsonApiResponse findAll(Iterable ids, QueryAdapter queryAdapter) { | ||
| RepositoryRequestFilterChainImpl chain = new RepositoryRequestFilterChainImpl() { |
There was a problem hiding this comment.
Reduce this anonymous class number of lines from 23 to at most 20, or make it a named class.
| } | ||
|
|
||
| public JsonApiResponse findAll(QueryAdapter queryAdapter) { | ||
| RepositoryRequestFilterChainImpl chain = new RepositoryRequestFilterChainImpl() { |
There was a problem hiding this comment.
Reduce this anonymous class number of lines from 22 to at most 20, or make it a named class.
|
|
||
| @SuppressWarnings("rawtypes") | ||
| public JsonApiResponse findOneTarget(I sourceId, String fieldName, QueryAdapter queryAdapter) { | ||
| RepositoryRequestFilterChainImpl chain = new RepositoryRequestFilterChainImpl() { |
There was a problem hiding this comment.
Reduce this anonymous class number of lines from 24 to at most 20, or make it a named class.
| .findOneTarget(sourceId, fieldName, request.getQueryParams()); | ||
| } | ||
| return getResponse(relationshipRepository, resource, request); | ||
| }; |
There was a problem hiding this comment.
Remove this empty statement.
|
|
||
| @SuppressWarnings("rawtypes") | ||
| public JsonApiResponse findManyTargets(I sourceId, String fieldName, QueryAdapter queryAdapter) { | ||
| RepositoryRequestFilterChainImpl chain = new RepositoryRequestFilterChainImpl() { |
There was a problem hiding this comment.
Reduce this anonymous class number of lines from 24 to at most 20, or make it a named class.
|
SonarQube analysis reported 12 issues
Watch the comments in this conversation to review them. |
new RepositoryFilter interface introduced that sits in the repository layer and allows to intercept request, respones and links/meta information gathering.
use cases: