Allow metrics collection #30
Comments
|
From @ieugen on May 18, 2016 11:49 We also need this and I going to do some work to add metrics. Please publish your work on a branch/project if you have something. |
|
From @ieugen on May 25, 2016 9:52 After the refactoring I'm going to work with https://github.com/astefanutti/metrics-aspectj to produce something useful and come back with results. I thing it's the least intrusive way of doing it. |
|
From @remmeier on June 29, 2016 18:30 +1 to use dropwizard metrics, is quite popular with already many other plugins |
|
next to dropwizard metrics zipkin/brave might also be worth investigating. As part of with #45 there is a request filter api similar to the one for servlets and jaxrs. That might be of help here too. And the metric part could then be implemented as a "module"/add-on to avoid additional dependencies in core. |
|
Any idea if this is possible in Katharsis 3? If I submitted a PR related to this would it be considered for being accepted? |
|
What metrics did you have in mind? On Thu, Nov 3, 2016, 3:39 PM Derek Bassett notifications@github.com wrote:
|
|
note that tracing is also on its way: #192 |
new RepositoryFilter interface introduced that sits in the repository layer and allows to intercept request, respones and links/meta information gathering. - repository adapters modified to invoke filters - filters get a chain class to decide whether to proceed with the request or return a result on its own. - RepositoryRequestSpec to specify the contents of a request - existing Filter interface should be renamed to make clear that they operate on a different layer (transport vs repository). - Module api extended to allow RepositoryFilter registration - minor refactoring to ResourceRegistry/ModuleRegistry dependency to allow access to RepositoryFilter
#30 RepositoryFilter to allow metrics collection
|
A new interface "RepositoryFilter" is available that can be registered with the modules. That should help quite a bit if somebody would like to implement a metrics module. |
|
Closing: There are any of several ways to do metrics on resources. Katharsis is not in that business. |
From @meshuga on April 21, 2016 20:7
Add metrics functionality for Katharsis. It should be possible to integrate with web framework functionalities e.g. Dropwizard/Jersey metrics (https://dropwizard.github.io/metrics/3.1.0/apidocs/com/codahale/metrics/jersey2/InstrumentedResourceMethodApplicationListener.html) or Spring metrics (https://docs.spring.io/spring-boot/docs/current/reference/html/production-ready-metrics.html). It should be possible to gather infomrations about requests and exceptions.
Plus add docs on how to do that.
Copied from original issue: katharsis-project/katharsis-core#299
The text was updated successfully, but these errors were encountered: