Skip to content

Commit

Permalink
Combine testComplexCast with testCast (facebookincubator#8254)
Browse files Browse the repository at this point in the history
Summary:
Combines `testComplexCast` and `testCast` into one to reduce redundant
interfaces. Some differences, including the test of input vector not being
changed after the evaluation, and caller specified nullOnFailure test, are
supported in `testCast` method. Removes `fromType` and `toType` parameters
from `testCast` method, as they can be deduced from input and expected
vectors.

Pull Request resolved: facebookincubator#8254

Reviewed By: xiaoxmeng

Differential Revision: D53107665

Pulled By: kagamiori

fbshipit-source-id: ddc4379eeb33e336bab2b0fab9760252a2421bf6
  • Loading branch information
rui-mo authored and facebook-github-bot committed Jan 26, 2024
1 parent ec3b082 commit 860e35b
Show file tree
Hide file tree
Showing 5 changed files with 190 additions and 327 deletions.
Loading

0 comments on commit 860e35b

Please sign in to comment.