Combine testComplexCast with testCast
#8254
Conversation
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
rui-mo
force-pushed
the
wip_test_cast
branch
3 times, most recently
from
d209f33
to
8aa8fea
Compare
rui-mo
force-pushed
the
wip_test_cast
branch
3 times, most recently
from
d70060d
to
fd3d9a7
Compare
| evaluateAndVerify( | ||
| fromType, | ||
| toType, | ||
| makeRowVector({constInput}), |
There was a problem hiding this comment.
nit: use constantRow here?
| } else { | ||
| evaluateAndVerify(fromType, toType, constantRow, constExpected); | ||
| evaluateAndVerify( | ||
| fromType, toType, makeRowVector({constInput}), constExpected, true); |
There was a problem hiding this comment.
nit: use constantRow instead of makeRowVector({constInput}) here?
|
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kagamiori merged this pull request in 860e35b. |
|
Conbench analyzed the 1 benchmark run on commit There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
Combines
testComplexCastandtestCastinto one to reduce redundantinterfaces. Some differences, including the test of input vector not being
changed after the evaluation, and caller specified nullOnFailure test, are
supported in
testCastmethod. RemovesfromTypeandtoTypeparametersfrom
testCastmethod, as they can be deduced from input and expectedvectors.