Dockerfile: reduce karmada website container image size by 28%

[mohamedawnallah]

Description

This commit optimizes the Karmada website's Docker container, reducing the image size from ~796MB to ~570MB, achieving a significant ~28% reduction.

The size reduction was achieved by:

• Using a multi-stage build approach: One stage for building the Node modules and another for running the server runtime.
• Consolidating RUN commands: Combining multiple RUN operations to reduce intermediate tarball files generated during those operations.

What type of PR is this?

/kind cleanup

Which issue(s) this PR fixes:
N/A

Special Notes for Reviewers:

• Verification:
  This optimization can be verified by comparing Docker image builds before and after the changes:
  

• Further Debugging:
  For deeper insights, the optimization can be analyzed using dive, a tool for exploring each layer in a Docker image.

[karmada-bot]

Welcome @mohamedawnallah! It looks like this is your first PR to karmada-io/website 🎉

[mohamedawnallah]

Hi @XiShanYongYe-Chang, @zhzhuang-zju,

I’ve submitted that PR and would appreciate any feedback you may have. Looking forward to your thoughts! 🙏

[zhzhuang-zju]

@mohamedawnallah Good job~ I'm not very good at this, but from your validation, it does look like a great optimization. With this optimization, is it possible to optimize the Karmada components images？

[mohamedawnallah]

is it possible to optimize the Karmada components images？

Yes, I would love to optimize the Karmada components images if I see any opportunities for optimization. I'm just wondering where the Dockerfiles are located?

[zhzhuang-zju]

I'm just wondering where the Dockerfiles are located?

you can find them in https://github.com/karmada-io/karmada/tree/master/cluster/images

[mohamedawnallah]

you can find them in https://github.com/karmada-io/karmada/tree/master/cluster/images

Thanks for sharing this! 🙏 I’ll take a look at them by the end of the day and submit a PR if I spot any opportunities for optimization. At first glance, I see that we could group the RUN commands together, and I’ll check for any other potential improvements.

[samzong]

great!

[mohamedawnallah]

from your validation, it does look like a great optimization. With this optimization, is it possible to optimize the Karmada components images?

@zhzhuang-zju I reviewed the Dockerfile specifications for all Karmada component images on Docker Hub (those prefixed with karmada/), and they are already optimized as of the time of writing this comment. While a few KBs could be saved by combining RUN commands, I think it's unnecessary and could reduce the readability of the Dockerfile.

[mohamedawnallah]

Regards that PR, How am I supposed to move it forward?

cc: @XiShanYongYe-Chang, @zhzhuang-zju

[zhzhuang-zju]

Regards that PR, How am I supposed to move it forward?

If all the CI checks pass and there is no impact on the deployment of the website, then it's ok with me.

[XiShanYongYe-Chang]

Thanks @mohamedawnallah
/assign @samzong

[samzong]

/approve
/lgtm

[karmada-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: samzong
Once this PR has been reviewed and has the lgtm label, please assign rainbowmango for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[XiShanYongYe-Chang]

Hi @mohamedawnallah, the CI is failed.

[zhzhuang-zju]

Hi @mohamedawnallah, the CI is failed.

#764 has encountered the same error. I suspect that it is caused by fluctuations in the CI operating environment.

/retest

[mohamedawnallah]

It seems the CI hasn't been re-triggered after /retest and also after closing and reopening the PR?

[zhzhuang-zju]

/retest

[zhzhuang-zju]

It seems the CI hasn't been re-triggered after /retest and also after closing and reopening the PR?

Yeah, for some reason, /retest doesn't work. You can try to update your commit to trigger ci.

[mohamedawnallah]

I've seen this issue in the netlify deployment error:

12:42:35 PM: FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory

I've updated netlify.toml to increase the memory allocation for NodeJS up to 4GB. May be this solve the issue entirely.

[build]
command = "NODE_OPTIONS=\"--max_old_space_size=4096\" yarn run build"

Not sure if netlify CI should be triggered automatically here

EDIT:
Yes I found them running here let's see:
https://app.netlify.com/sites/karmada/deploys/67be733528974f00082a028d

[XiShanYongYe-Chang]

The CI is passed, thanks~
/lgtm
/cc @RainbowMango

[karmada-bot]

New changes are detected. LGTM label has been removed.

[RainbowMango]

Could you please squash the commits? And I think we are ready to go after that.