-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zh: adds karmadactl flags for proper display #764
Conversation
karmadactl introduced the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/retest |
https://app.netlify.com/sites/karmada/deploys/675fce07d8baa700087e6d73#L164 |
0405eed
to
43fc71a
Compare
43fc71a
to
29baddc
Compare
CI [Header rules] almost always fails in these two days, with the following logs: Found a related solution in netlify's FAQ to increase NodeJS memory by adding |
Reducing the number of maintained documents seems to solve this issue too. Could we limit ourselves to keeping only a fixed number of document versions? For example, the last three minor releases. |
I understand the root cause of this issue is that the website is getting bigger and bigger, which requires more memory to build. The solution mentioned above (#764 (comment)) is essentially a workaround, if we do not clean the EOL docs, we are likely to face this issue again shortly. So, I tend to cleanup the EOL docs. But we need a way to back up before removing them. |
I just created https://github.com/karmada-io/website/tree/release-1.12 branch which can be used as a backup, but we need to explore if we need further configuration on Netlify. |
I can start by understanding what configurations are available for Netlify |
64e64d4
to
2c30c3c
Compare
By removing the index of EOL docs from |
I prefer to remove them from the code base.
How about keeping the latest 6 releases? |
2c30c3c
to
29baddc
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
29baddc
to
9ce64cc
Compare
Signed-off-by: zhzhuang-zju <m17799853869@163.com>
9ce64cc
to
45fae10
Compare
The good news is that no changes are required to pass the CI; the bad news is that this makes me unsure about the actual reason for the previous failure. 😕 |
/lgtm So, no evidence that this error is due to too many docs. :) We can start to handle it when we face it next time. |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Refer to #763 (comment)
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: