Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update verify-artifact for helm chart #473

Closed
wants to merge 1 commit into from
Closed

Update verify-artifact for helm chart #473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/administrator/verify-artifacts.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ You need to install the following tools:

Karmada introduced the `cosign` verification tool since release 1.7. For a list of published mirrors, see [karmada mirrors](https://hub.docker.com/u/karmada).

> Note: image of helm chart introduced the `cosign` verification tool since release 1.8.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> Note: image of helm chart introduced the `cosign` verification tool since release 1.8.
> Note: The image of the helm chart has introduced the `cosign` verification tool since Karmada v1.8.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Karmada v1.8.

Thanks for review, The doc is really have style like Karmada introduced the cosignverification tool since release 1.7., This may not need to be modified for consistency?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't understand why adding the notes under this chapter.
If we want to demonstrate how to verify Charts, we might need to organize the content as:

# Overview

## Images
## Charts    // new chapter
## Binaries

Note that this chapter is reserved when we setup the document at #449 (review).


Select an image from these images and verify its signature using `cosign verify` command：

```shell
Expand Down