-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update verify-artifact for helm chart #473
Conversation
Signed-off-by: Lan Liang <gcslyp@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @liangyuanpeng! It looks like this is your first PR to karmada-io/website 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text suggestions if my understanding is not wrong.
@@ -20,6 +20,8 @@ You need to install the following tools: | |||
|
|||
Karmada introduced the `cosign` verification tool since release 1.7. For a list of published mirrors, see [karmada mirrors](https://hub.docker.com/u/karmada). | |||
|
|||
> Note: image of helm chart introduced the `cosign` verification tool since release 1.8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> Note: image of helm chart introduced the `cosign` verification tool since release 1.8. | |
> Note: The image of the helm chart has introduced the `cosign` verification tool since Karmada v1.8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Karmada v1.8.
Thanks for review, The doc is really have style like Karmada introduced the
cosignverification tool since release 1.7.
, This may not need to be modified for consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't understand why adding the notes under this chapter.
If we want to demonstrate how to verify Charts, we might need to organize the content as:
# Overview
## Images
## Charts // new chapter
## Binaries
Note that this chapter is reserved when we setup the document at #449 (review).
This small PR has remained for 9 months while it has conflicts. Feel free to re-open it if you have more suggestions, thanks. /close |
@windsonsea: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Update doc of verify-artifact for helm chart.
Related:
TODO also update to doc of zh.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: