Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #3098: support pod subresource (attach, exec, port-forward) through #3100

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Automated cherry pick of #3098: support pod subresource (attach, exec, port-forward) through #3100

merged 1 commit into from
Feb 2, 2023

Conversation

ikaven1024
Copy link
Member

@ikaven1024 ikaven1024 commented Feb 2, 2023 •
edited by RainbowMango
Loading

Cherry pick of #3098 on release-1.4.
#3098: support pod subresource (attach, exec, port-forward) through
For details on the cherry pick process, see the cherry pick requests page.

`karmada-search`: support pod subresource (attach, exec, port-forward) through global proxy.

@ikaven1024
support pod subresource (attach, exec, port-forward) through global p…
acb1361 
…roxy

Signed-off-by: yingjinhui <yingjinhui@didiglobal.com>
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 2, 2023
XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Feb 2, 2023
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2023
@XiShanYongYe-Chang
Copy link
Member

/release-note-edit `karmada-search`: support pod subresource (attach, exec, port-forward) through global proxy

@XiShanYongYe-Chang
Copy link
Member

/release-note-edit `karmada-search`: support pod subresource (attach, exec, port-forward) through global proxy

It seems not to work. Hi @ikaven1024, can you help update it?

@ikaven1024
Copy link
Member Author

/release-note-edit `karmada-search`: support pod subresource (attach, exec, port-forward) through global proxy

It seems not to work. Hi @ikaven1024, can you help update it?

Done

@karmada-bot karmada-bot merged commit 5b5e781 into karmada-io:release-1.4 Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@huntsman-li huntsman-li Awaiting requested review from huntsman-li

Assignees

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikaven1024 @karmada-bot @XiShanYongYe-Chang