Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support pod subresource (attach, exec, port-forward) through global proxy #3098

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

ikaven1024
Copy link
Member

Signed-off-by: yingjinhui yingjinhui@didiglobal.com

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #3089

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-search`: support pod subresource (attach, exec, port-forward) through global proxy

…roxy

Signed-off-by: yingjinhui <yingjinhui@didiglobal.com>
@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 1, 2023
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 1, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3098 (167e132) into master (8f83031) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #3098   +/-   ##
=======================================
  Coverage   44.38%   44.38%           
=======================================
  Files         208      208           
  Lines       19518    19521    +3     
=======================================
+ Hits         8663     8665    +2     
- Misses      10373    10374    +1     
  Partials      482      482           
Flag Coverage Δ
unittests 44.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../search/proxy/framework/plugins/cluster/cluster.go 74.39% <100.00%> (+0.97%) ⬆️
pkg/search/proxy/store/util.go 92.89% <0.00%> (-0.48%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@RainbowMango RainbowMango added this to the v1.5 milestone Feb 2, 2023
@RainbowMango
Copy link
Member

/assign @XiShanYongYe-Chang

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!
/lgtm
/approve

We may need to cherry-pick this patch to the before release.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2023
@karmada-bot karmada-bot merged commit 1d32ab6 into karmada-io:master Feb 2, 2023
@ikaven1024
Copy link
Member Author

Shall I cherry-pick it to previous release? @RainbowMango

@ikaven1024 ikaven1024 deleted the fix-proxy branch February 2, 2023 02:42
@RainbowMango
Copy link
Member

Do you think this is a bug?

@ikaven1024
Copy link
Member Author

pods attach/exec/port-forward shall be supported at the beginning design. So I think it's a bug.

@XiShanYongYe-Chang
Copy link
Member

I think @vkukul maybe also need this patch in the previous release.

@ikaven1024
Copy link
Member Author

ikaven1024 commented Feb 2, 2023

I can't cherry pick it to release 1.3 due to we have refactor the code after 1.3: #2678

@XiShanYongYe-Chang
Copy link
Member

I can't cherry pick it to release 1.3 due to we have refactor the code after 1.3: #2678

Looks like manual intervention is required.

karmada-bot added a commit that referenced this pull request Feb 2, 2023
…98-upstream-release-1.4

Automated cherry pick of #3098: support pod subresource (attach, exec, port-forward) through
karmada-bot added a commit that referenced this pull request Feb 7, 2023
…k-of-#3098-upstream-release-1.3

Automated cherry pick of #3098: support pod subresource (attach, exec, port-forward) through
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pod subresource (attach, exec, port-forward) support through global proxy
5 participants