-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support pod subresource (attach, exec, port-forward) through global proxy #3098
Conversation
…roxy Signed-off-by: yingjinhui <yingjinhui@didiglobal.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #3098 +/- ##
=======================================
Coverage 44.38% 44.38%
=======================================
Files 208 208
Lines 19518 19521 +3
=======================================
+ Hits 8663 8665 +2
- Misses 10373 10374 +1
Partials 482 482
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/assign @XiShanYongYe-Chang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
/lgtm
/approve
We may need to cherry-pick this patch to the before release.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Shall I cherry-pick it to previous release? @RainbowMango |
Do you think this is a bug? |
pods attach/exec/port-forward shall be supported at the beginning design. So I think it's a bug. |
I think @vkukul maybe also need this patch in the previous release. |
I can't cherry pick it to release 1.3 due to we have refactor the code after 1.3: #2678 |
Looks like manual intervention is required. |
…98-upstream-release-1.4 Automated cherry pick of #3098: support pod subresource (attach, exec, port-forward) through
…k-of-#3098-upstream-release-1.3 Automated cherry pick of #3098: support pod subresource (attach, exec, port-forward) through
Signed-off-by: yingjinhui yingjinhui@didiglobal.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3089
Special notes for your reviewer:
Does this PR introduce a user-facing change?: