Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammar error in log message when browser does not capture in time #3716

Closed
Infir3 opened this issue Oct 26, 2021 · 3 comments · Fixed by #3725 · May be fixed by Infir3/karma#1
Closed

Grammar error in log message when browser does not capture in time #3716

Infir3 opened this issue Oct 26, 2021 · 3 comments · Fixed by #3725 · May be fixed by Infir3/karma#1
Labels
released

Comments

@Infir3
Copy link
Contributor

Infir3 commented Oct 26, 2021

karma/lib/launchers/capture_timeout.js

Line 20 in 94cf15e

log.warn(`${this.name} have not captured in ${captureTimeout} ms, killing.`)

Should probably be "... has not captured in ..."
@jginsburgn
Copy link
Member

Thanks for noticing that. Are you willing to submit a PR?

Infir3 pushed a commit to Infir3/karma that referenced this issue Nov 11, 2021
@stefan-becking-webcom
style: fix grammar error in browser capture log message
beebcf7 
Fixes a grammar error in the log message when a browser does not capture in time.

Fixes karma-runner#3716
This was referenced Nov 11, 2021
Open
Merged
Infir3 pushed a commit to Infir3/karma that referenced this issue Nov 11, 2021
@stefan-becking-webcom
style: fix grammar error in browser capture log message
87caba6 
Fixes a grammar error in the log message when a browser does not capture in time.

Fixes karma-runner#3716
Infir3 pushed a commit to Infir3/karma that referenced this issue Nov 11, 2021
@stefan-becking-webcom
style: fix grammar error in browser capture log message
4b8c768 
Fixes a grammar error in the log message when a browser does not capture in time.

Fixes karma-runner#3716
@Infir3
Copy link
Contributor Author

Infir3 commented Nov 11, 2021

Took me a while, but here it is: #3725 😃

jginsburgn pushed a commit that referenced this issue Nov 11, 2021
@stefan-becking-webcom
style: fix grammar error in browser capture log message
b153355 
Fixes a grammar error in the log message when a browser does not capture in time.

Fixes #3716
@karmarunnerbot
Copy link
Member

🎉 This issue has been resolved in version 6.3.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

anthony-redFox pushed a commit to anthony-redFox/karma that referenced this issue May 16, 2023
@stefan-becking-webcom @anthony-redFox
style: fix grammar error in browser capture log message
be895c9 
Fixes a grammar error in the log message when a browser does not capture in time.

Fixes karma-runner#3716
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
3 participants
@karmarunnerbot @Infir3 @jginsburgn