Skip to content

Commit

Permalink
style: fix grammar error in browser capture log message
Browse files Browse the repository at this point in the history
Fixes a grammar error in the log message when a browser does not capture in time.

Fixes #3716
  • Loading branch information
stefan-becking-webcom authored and Jonathan Ginsburg committed Nov 11, 2021
1 parent 8f798d5 commit b153355
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions docs/config/01-configuration-file.md
Original file line number Diff line number Diff line change
Expand Up @@ -853,11 +853,11 @@ When running a browser in different environments, it can take different amounts
client socket to connect. If Karma cannot connect within the default timeout, you may see an
error similar to the following:
```
ChromeHeadless have not captured in 60000ms, killing.
ChromeHeadless has not captured in 60000ms, killing.
Trying to start ChromeHeadless again (1/2).
ChromeHeadless have not captured in 60000ms, killing.
ChromeHeadless has not captured in 60000ms, killing.
Trying to start ChromeHeadless again (2/2).
ChromeHeadless have not captured in 60000ms, killing.
ChromeHeadless has not captured in 60000ms, killing.
ChromeHeadless failed 2 times(timeout). Giving up.
```
If you see this error, you can try increasing the socket connection timeout.
Expand Down
2 changes: 1 addition & 1 deletion lib/launchers/capture_timeout.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ function CaptureTimeoutLauncher (timer, captureTimeout) {
return
}

log.warn(`${this.name} have not captured in ${captureTimeout} ms, killing.`)
log.warn(`${this.name} has not captured in ${captureTimeout} ms, killing.`)
this.error = 'timeout'
this.kill()
}, captureTimeout)
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/timeout.feature
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ Feature: Timeout
When I start Karma
Then it fails with like:
"""
have not captured in 100 ms
has not captured in 100 ms
"""

0 comments on commit b153355

Please sign in to comment.