Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WordPress Term Retrieval Error Checks #6

Merged
merged 1 commit into from
Oct 26, 2023
Merged

WordPress Term Retrieval Error Checks #6

merged 1 commit into from
Oct 26, 2023

Conversation

rleeson
Copy link
Contributor

@rleeson rleeson commented Oct 26, 2023

Description

As a developer, I need to ensure fatal errors don't occur when retrieving terms

  • Add WP_Error checks when searching for taxonomy terms

Steps to Validate

  1. Pull the branch into an existing project which uses Taxonomy Term and Post Term retrieval
  2. Run the import/export routine for invalid taxonomies
  3. Verify Fatal Errors are no longer thrown

damonsharp
damonsharp approved these changes Oct 26, 2023
View reviewed changes
Copy link

@damonsharp damonsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rleeson - code looks fine.

@rleeson rleeson merged commit 564f279 into main Oct 26, 2023
@rleeson rleeson deleted the hotfix/terms-error branch October 26, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damonsharp damonsharp damonsharp approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rleeson @damonsharp