Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Modify Create DB instance in RDS test to use DBsubnetGroup #1959

Merged
merged 52 commits into from
Mar 30, 2023
Merged
Show file tree
Hide file tree
Changes from 50 commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
1a696a7
Update RDS postgres app implementation, execute postgres command from…
akankshakumari393 Mar 9, 2023
b6619d8
Fix Lint Remove unnecessary trailing new line
akankshakumari393 Mar 9, 2023
8b3803c
Initialize testWorkloadName field
akankshakumari393 Mar 9, 2023
7f8b439
Move BastionWorkload function to be used as utility
akankshakumari393 Mar 10, 2023
1eefdd5
Minor refactor
akankshakumari393 Mar 10, 2023
8c0f1fb
Remove export of BastionWorkload() utility function
akankshakumari393 Mar 10, 2023
e2c9809
Add app name in error messages
akankshakumari393 Mar 10, 2023
f11cb7f
Minor refactor
akankshakumari393 Mar 10, 2023
0f87952
Minor refactor
akankshakumari393 Mar 10, 2023
4e6a7b6
Update RDS Aurora app implementation, execute mysql query from Deploy…
akankshakumari393 Mar 10, 2023
da665de
Remove unused methods from rds aurora app
akankshakumari393 Mar 10, 2023
3952de1
Minor refactor
akankshakumari393 Mar 10, 2023
a6514c0
Add helper methods to add DBSubnetGroup
akankshakumari393 Mar 10, 2023
4442497
add callers to create and delete dbsubnetGroups in rds postgres app test
akankshakumari393 Mar 10, 2023
3691915
add callers to create and delete dbsubnetGroups in rds aurora app test
akankshakumari393 Mar 10, 2023
9748a04
Refactor code
akankshakumari393 Mar 10, 2023
6745c9f
Refactor code
akankshakumari393 Mar 10, 2023
ee35531
remove duplicate import
akankshakumari393 Mar 10, 2023
7d5078a
minor refactor
akankshakumari393 Mar 10, 2023
3387d47
Merge branch 'use_pod_rds_aurora' into aws_rds_secure
akankshakumari393 Mar 10, 2023
c209ab6
correct indentation
akankshakumari393 Mar 10, 2023
c346707
Fix error
akankshakumari393 Mar 10, 2023
a293e9c
Minor refactor
akankshakumari393 Mar 12, 2023
588f0b7
Minor refactor
akankshakumari393 Mar 12, 2023
587d079
Update RDS Aurora app implementation, execute mysql query from Deploy…
akankshakumari393 Mar 10, 2023
a455ec7
Remove unused methods from rds aurora app
akankshakumari393 Mar 10, 2023
c4bd0c2
Minor refactor
akankshakumari393 Mar 10, 2023
df66bb4
minor refactor
akankshakumari393 Mar 10, 2023
523230e
Minor refactor
akankshakumari393 Mar 12, 2023
4b32010
Merge branch 'use_pod_rds_aurora' into aws_rds_secure
akankshakumari393 Mar 12, 2023
4b10821
Modify Create RDS Snapshot function to add dbSubnetGroup as outputArt…
akankshakumari393 Mar 13, 2023
7acb128
Modify RestoreRDSSnapshot and ExportRDSLocation function to accept db…
akankshakumari393 Mar 13, 2023
5462b6c
Add provision to enable/disable public access for RDS instances creat…
akankshakumari393 Mar 14, 2023
3505048
Pass VpcId while creating security group
akankshakumari393 Mar 15, 2023
f7ee189
Modify Create RDS Snapshot function to add dbSubnetGroup as outputArt…
akankshakumari393 Mar 13, 2023
f92c57e
Modify RestoreRDSSnapshot and ExportRDSLocation function to accept db…
akankshakumari393 Mar 13, 2023
ccb284f
Merge branch 'modify_restore_rds_snap' into rds_public_access
akankshakumari393 Mar 15, 2023
9543724
Use securityGroup ID instead of security group name to authorizeSecur…
akankshakumari393 Mar 15, 2023
ea422dd
Modify Create RDS Snapshot function to add dbSubnetGroup as outputArt…
akankshakumari393 Mar 13, 2023
6c9f27b
Modify RestoreRDSSnapshot and ExportRDSLocation function to accept db…
akankshakumari393 Mar 13, 2023
6e2e189
Merge branch 'modify_restore_rds_snap' into rds_public_access
akankshakumari393 Mar 15, 2023
77ee4d2
Minor Fix
akankshakumari393 Mar 15, 2023
b3d7cf2
Modify Create RDS Snapshot function to add dbSubnetGroup as outputArt…
akankshakumari393 Mar 13, 2023
284acc5
Modify RestoreRDSSnapshot and ExportRDSLocation function to accept db…
akankshakumari393 Mar 13, 2023
ab82bd4
Merge branch 'modify_restore_rds_snap' into rds_public_access
akankshakumari393 Mar 15, 2023
e9b6ebe
Modify RDS postgres blueprint to use DBsubnetGroup
akankshakumari393 Mar 14, 2023
e55ba0b
Modify RDS postgres dump blueprint to use DBsubnetGroup
akankshakumari393 Mar 14, 2023
ca81568
Modify RDS postgres snap blueprint to use DBsubnetGroup
akankshakumari393 Mar 14, 2023
b7be5b5
Modify RDS Aurora snap blueprint example to use DBsubnetGroup
akankshakumari393 Mar 14, 2023
3eb98f0
Modify Create Db instance in test to us DbsubnetGroup
akankshakumari393 Mar 15, 2023
a912f97
Merge branch 'master' into pass_vpc_id
akankshakumari393 Mar 30, 2023
c4cd7cb
Resolve merge conflict
akankshakumari393 Mar 30, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions examples/aws-rds/aurora-mysql/rds-aurora-snap-blueprint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ actions:
instanceID: "{{ .Phases.createSnapshot.Output.instanceID }}"
securityGroupID: "{{ .Phases.createSnapshot.Output.securityGroupID }}"
allocatedStorage: "{{ .Phases.createSnapshot.Output.allocatedStorage }}"
dbSubnetGroup: "{{ .Phases.createSnapshot.Output.dbSubnetGroup }}"
phases:
- func: CreateRDSSnapshot
name: createSnapshot
Expand All @@ -28,6 +29,7 @@ actions:
snapshotID: "{{ .ArtifactsIn.backupInfo.KeyValue.snapshotID }}"
securityGroupID: "{{ .ArtifactsIn.backupInfo.KeyValue.securityGroupID }}"
dbEngine: "aurora-mysql"
dbSubnetGroup: "{{ .ArtifactsIn.backupInfo.KeyValue.dbSubnetGroup }}"
delete:
inputArtifactNames:
- backupInfo
Expand Down
6 changes: 5 additions & 1 deletion examples/aws-rds/postgresql/rds-postgres-blueprint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ actions:
keyValue:
id: '{{ .Object.metadata.namespace }}-{{ toDate "2006-01-02T15:04:05.999999999Z07:00" .Time | date "2006-01-02T15-04-05" }}'
sgid: "{{ .Phases.backupSnapshots.Output.securityGroupID }}"
dbSubnetGroup: "{{ .Phases.backupSnapshots.Output.dbSubnetGroup }}"
phases:
- func: KubeTask
name: backupSnapshots
Expand Down Expand Up @@ -42,6 +43,9 @@ actions:

vpcsgid=$(aws rds describe-db-instances --db-instance-identifier="{{ index .Object.data "postgres.instanceid" }}" --region "{{ .Profile.Location.Region }}" --query 'DBInstances[].VpcSecurityGroups[].VpcSecurityGroupId' --output text)
kando output securityGroupID $vpcsgid

dbSubnetGroup=$(aws rds describe-db-instances --db-instance-identifier="{{ index .Object.data "postgres.instanceid" }}" --region "{{ .Profile.Location.Region }}" --query 'DBInstances[0].DBSubnetGroup.DBSubnetGroupName' --output text)
kando output dbSubnetGroup $dbSubnetGroup
restore:
inputArtifactNames:
- snapshot
Expand Down Expand Up @@ -77,7 +81,7 @@ actions:
aws rds wait db-instance-deleted --region "{{ .Profile.Location.Region }}" --db-instance-identifier="{{ index .Object.data "postgres.instanceid" }}"

# Restore instance from snapshot
aws rds restore-db-instance-from-db-snapshot --db-instance-identifier="{{ index .Object.data "postgres.instanceid" }}" --db-snapshot-identifier="{{ .ArtifactsIn.snapshot.KeyValue.id }}" --vpc-security-group-ids "{{ .ArtifactsIn.snapshot.KeyValue.sgid }}" --region "{{ .Profile.Location.Region }}"
aws rds restore-db-instance-from-db-snapshot --db-instance-identifier="{{ index .Object.data "postgres.instanceid" }}" --db-snapshot-identifier="{{ .ArtifactsIn.snapshot.KeyValue.id }}" --vpc-security-group-ids "{{ .ArtifactsIn.snapshot.KeyValue.sgid }}" --region "{{ .Profile.Location.Region }}" --db-subnet-group-name "{{ .ArtifactsIn.snapshot.KeyValue.dbSubnetGroup }}"
aws rds wait db-instance-available --region "{{ .Profile.Location.Region }}" --db-instance-identifier="{{ index .Object.data "postgres.instanceid" }}"
delete:
inputArtifactNames:
Expand Down
4 changes: 3 additions & 1 deletion examples/aws-rds/postgresql/rds-postgres-dump-blueprint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ actions:
instanceID: "{{ .Phases.createSnapshot.Output.instanceID }}"
securityGroupID: "{{ .Phases.createSnapshot.Output.securityGroupID }}"
backupID: "{{ .Phases.exportSnapshot.Output.backupID }}"
dbSubnetGroup: "{{ .Phases.createSnapshot.Output.dbSubnetGroup }}"
phases:
- func: CreateRDSSnapshot
name: createSnapshot
Expand All @@ -33,6 +34,7 @@ actions:
databases: '{{ index .Object.data "postgres.databases" }}'
snapshotID: "{{ .Phases.createSnapshot.Output.snapshotID }}"
backupArtifactPrefix: test-postgresql-instance/postgres
dbSubnetGroup: "{{ .Phases.createSnapshot.Output.dbSubnetGroup }}"
- func: DeleteRDSSnapshot
name: deleteSnapshot
args:
Expand All @@ -57,7 +59,7 @@ actions:
username: '{{ index .Phases.restoreSnapshots.Secrets.dbsecret.Data "username" | toString }}'
password: '{{ index .Phases.restoreSnapshots.Secrets.dbsecret.Data "password" | toString }}'
dbEngine: "PostgreSQL"

dbSubnetGroup: "{{ .ArtifactsIn.backupInfo.KeyValue.dbSubnetGroup }}"
delete:
phases:
- func: KubeTask
Expand Down
2 changes: 2 additions & 0 deletions examples/aws-rds/postgresql/rds-postgres-snap-blueprint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ actions:
instanceID: "{{ .Phases.createSnapshot.Output.instanceID }}"
securityGroupID: "{{ .Phases.createSnapshot.Output.securityGroupID }}"
allocatedStorage: "{{ .Phases.createSnapshot.Output.allocatedStorage }}"
dbSubnetGroup: "{{ .Phases.createSnapshot.Output.dbSubnetGroup }}"
phases:
- func: CreateRDSSnapshot
name: createSnapshot
Expand All @@ -26,6 +27,7 @@ actions:
instanceID: "{{ .ArtifactsIn.backupInfo.KeyValue.instanceID }}"
snapshotID: "{{ .ArtifactsIn.backupInfo.KeyValue.snapshotID }}"
securityGroupID: "{{ .ArtifactsIn.backupInfo.KeyValue.securityGroupID }}"
dbSubnetGroup: "{{ .ArtifactsIn.backupInfo.KeyValue.dbSubnetGroup }}"
delete:
inputArtifactNames:
- backupInfo
Expand Down
Loading