Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] Modify Create DB instance in RDS test to use DBsubnetGroup #1959

Merged
merged 52 commits into from
Mar 30, 2023
Merged

[Minor] Modify Create DB instance in RDS test to use DBsubnetGroup #1959

merged 52 commits into from
Mar 30, 2023

Conversation

akankshakumari393
Copy link
Contributor

Change Overview

This PR modifies the creation of DBInstance in RDS Test to use DBSubnetGroup. This is required in case VPC associated with securityGroup is not default.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@akankshakumari393
Update RDS postgres app implementation, execute postgres command from…
1a696a7 
… Deployment

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Fix Lint Remove unnecessary trailing new line
b6619d8 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Initialize testWorkloadName field
8b3803c 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Move BastionWorkload function to be used as utility
7f8b439
@akankshakumari393
Minor refactor
1eefdd5 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Remove export of BastionWorkload() utility function
8c0f1fb 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Add app name in error messages
e2c9809 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Minor refactor
f11cb7f 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Minor refactor
0f87952 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Update RDS Aurora app implementation, execute mysql query from Deploy…
4e6a7b6 
…ment

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Remove unused methods from rds aurora app
da665de 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Minor refactor
3952de1 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Add helper methods to add DBSubnetGroup
a6514c0 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
add callers to create and delete dbsubnetGroups in rds postgres app test
4442497 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
add callers to create and delete dbsubnetGroups in rds aurora app test
3691915 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Refactor code
9748a04
@akankshakumari393
Refactor code
6745c9f 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
remove duplicate import
ee35531 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
minor refactor
7d5078a
@akankshakumari393
Merge branch 'use_pod_rds_aurora' into aws_rds_secure
3387d47
@akankshakumari393
correct indentation
c209ab6
@akankshakumari393
Fix error
c346707
@akankshakumari393
Minor refactor
a293e9c 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Minor refactor
588f0b7 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Update RDS Aurora app implementation, execute mysql query from Deploy…
587d079 
…ment

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Remove unused methods from rds aurora app
a455ec7 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Minor refactor
c4bd0c2 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
minor refactor
df66bb4
@akankshakumari393
Minor refactor
523230e
@akankshakumari393
Merge branch 'use_pod_rds_aurora' into aws_rds_secure
4b32010
@akankshakumari393
Modify RestoreRDSSnapshot and ExportRDSLocation function to accept db…
6c9f27b 
…SubnetGroup as optional argument

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Merge branch 'modify_restore_rds_snap' into rds_public_access
6e2e189
@akankshakumari393
Minor Fix
77ee4d2
@akankshakumari393
Modify Create RDS Snapshot function to add dbSubnetGroup as outputArt…
b3d7cf2 
…ifact
@akankshakumari393
Modify RestoreRDSSnapshot and ExportRDSLocation function to accept db…
284acc5 
…SubnetGroup as optional argument

Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Merge branch 'modify_restore_rds_snap' into rds_public_access
ab82bd4
@akankshakumari393
Modify RDS postgres blueprint to use DBsubnetGroup
e9b6ebe 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Modify RDS postgres dump blueprint to use DBsubnetGroup
e55ba0b 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Modify RDS postgres snap blueprint to use DBsubnetGroup
ca81568
@akankshakumari393
Modify RDS Aurora snap blueprint example to use DBsubnetGroup
b7be5b5 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393
Modify Create Db instance in test to us DbsubnetGroup
3eb98f0 
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393 akankshakumari393 changed the title [Minor] Modify Create Db instance in RDS test to use DbsubnetGroup [Minor] Modify Create DB instance in RDS test to use DBsubnetGroup Mar 15, 2023
@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@akankshakumari393 akankshakumari393 changed the base branch from update_bleuprint to master March 28, 2023 14:44
@akankshakumari393 akankshakumari393 changed the base branch from master to update_bleuprint March 28, 2023 14:44
Base automatically changed from update_bleuprint to master March 30, 2023 03:59
@mergify mergify bot merged commit 22e52b1 into master Mar 30, 2023
@mergify mergify bot deleted the pass_vpc_id branch March 30, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrasadG193 PrasadG193 PrasadG193 approved these changes

@viveksinghggits viveksinghggits Awaiting requested review from viveksinghggits

@pavannd1 pavannd1 Awaiting requested review from pavannd1

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akankshakumari393 @PrasadG193