Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKIP_SMOKE_TESTS ignored #17

Closed
chrisspen opened this issue Aug 11, 2020 · 1 comment
Closed

SKIP_SMOKE_TESTS ignored #17

chrisspen opened this issue Aug 11, 2020 · 1 comment

Comments

@chrisspen
Copy link

chrisspen commented Aug 11, 2020

This may be more a request for documentation, but it's unclear what the format of SKIP_SMOKE_TESTS should be.

How do you specify a URL to ignore? The README implies it should be the same name that's accepted by reverse(), but this doesn't seem to be true.

For example, smoke_tests currently complains about /admin/myapp/mymodel/add/ with the notorious error:

 django.core.exceptions.ValidationError: ['ManagementForm data is missing or has been tampered with']

The traceback returned touches none of my own code, so there's no way for me to fix this, so I'd like smoke_tests to skip this path.

You'd think adding admin:myapp_mymodel_add to the SKIP_SMOKE_TESTS list would skip this path, but it has no effect. I've tried all of these patterns:

'admin:myapp_mymodel_add'
'^admin/myapp/mymodel/add/'
'/admin/myapp/mymodel/add/'
'/admin/myapp/mymodel/add'

and none of them skip that path.

kamilkijak added a commit that referenced this issue Apr 7, 2022
Fix #17 - support URL namespaces in SKIP_SMOKE_TESTS
@kamilkijak
Copy link
Owner

Thank you @chrisspen, there was a bug in the code. A fix has been released in v2.0.0, let me know if you have any other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants