Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKIP_SMOKE_TESTS doesnt accept namespaces #14

Closed
jayvdb opened this issue Jun 16, 2020 · 1 comment
Closed

SKIP_SMOKE_TESTS doesnt accept namespaces #14

jayvdb opened this issue Jun 16, 2020 · 1 comment

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Jun 16, 2020

  • django-smoke-tests version: master++
  • Django version: 3.0.7
  • Python version: 3.8
  • Operating System: openSUSE Tumbleweed

Description

I am using django-oscar , which has a bunch of failures across its many constituted apps, including the following three views

'dashboard:catalogue-attribute-option-group-create',
'dashboard:catalogue-class-create',
'dashboard:catalogue-product-create',

However, I need to omit the namespace when I put them into SKIP_SMOKE_TESTS.
i.e.

'catalogue-attribute-option-group-create',
'catalogue-class-create',
'catalogue-product-create',

There are others like 'customer:order' which need to become 'order'.
I am sure that I will have a few cases of view names which need a namespace in order to be distinct, but I guess the skip would apply to all with the same name, so that outcome isnt terrible.

However more importantly, it took me a while to recognise that the namespace needed to be omitted. A quick README update would be helpful, if a proper solution isnt easy.

@kamilkijak
Copy link
Owner

Related to #17.

It has been fixed in v2.0.0. Thanks @jayvdb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants