Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools] Prefer tarballs from GitHub for reliability #4336

Merged
merged 1 commit into from
Nov 16, 2020

Commits on Nov 15, 2020

  1. [tools] Prefer tarballs from GitHub for reliability

    * Software distributed on GitHub is downloaded from GitHub:
      - cub (official): rework rules to avoid excessive re-downloads,
        and change tarball format to .tar.gz to match other software.
      - SCTK (official)
      - sph2pipe (mirror at burrmill, stable)
    
    * Fix build of sph2pipe. Some tarballs of the same version 2.5
      did not accept the patch from extras/, and make -j N for large N
      stopped on a prompt from patch(1) that has scrolled far up,
      creating an impression that make had hung. The currently used
      mirror does not require a patch, and cleanly builds with its own
      Makefile. Rework build rules to use the Makefile, and remove
      the patch.
    
    * Retire 'openblas' rule: it no longer invokes install_openblas.sh
      and directs the user to use the script instead. The rule was
      incorrect, because it ignored OPENBLAS_VERSION manifestly set in
      the Makefile
    
    * Remove a patch for SCTK: its only purpose had been to add missing
      #include's and declarations, which generated warnings in C code.
      Instead, suppress all compilation warnings during build.
    
    Fixes: kaldi-asr#4311
    Fixes: kaldi-asr#4323
    kkm000 committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    064d319 View commit details
    Browse the repository at this point in the history