[tools] Prefer tarballs from GitHub for reliability #4336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Software distributed on GitHub is downloaded from GitHub:
- cub (official): rework rules to avoid excessive re-downloads,
and change tarball format to .tar.gz to match other software.
- SCTK (official)
- sph2pipe (mirror at burrmill, stable)
* Fix build of sph2pipe. Some tarballs of the same version 2.5
did not accept the patch from extras/, and make -j N for large N
stopped on a prompt from patch(1) that has scrolled far up,
creating an impression that make had hung. The currently used
mirror does not require a patch, and cleanly builds with its own
Makefile. Rework build rules to use the Makefile, and remove
the patch.
* Retire 'openblas' rule: it no longer invokes install_openblas.sh
and directs the user to use the script instead. The rule was
incorrect, because it ignored OPENBLAS_VERSION manifestly set in
the Makefile
* Remove a patch for SCTK: its only purpose had been to add missing
#include's and declarations, which generated warnings in C code.
Instead, suppress all compilation warnings during build.
Fixes: kaldi-asr#4311
Fixes: kaldi-asr#4323
|
OK with me! You can merge if you think it's OK.. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Software distributed on GitHub is downloaded from GitHub:
Fix build of
sph2pipe. Some tarballs of the very same version 2.5 did not accept the patch fromextras/cleanly, andmake -jN for large N stopped on a prompt from patch(1) that has scrolled far up, creating an impression that make had hung. The currently used mirror does not require a patch, and cleanly builds with its own Makefile. Rework build rules to use the Makefile, and remove the patch.Retire
openblasrule: it no longer invokesinstall_openblas.sh, and directs the user to use the script instead. The rule was incorrect because it ignoredOPENBLAS_VERSIONmanifestly set in the MakefileRemove a patch for SCTK: its only purpose had been to add missing #include's and declarations, which generated warnings in C code. Instead, suppress all compilation warnings during build.
Fixes: #4311
Fixes: #4323