-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump and adapt to new kairos-init #3214
Changes from all commits
73f6bcf
c094fe6
2715ec4
25b472f
a4df5dd
d607706
cf0f80c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,30 +1,18 @@ | ||
ARG BASE_IMAGE=ubuntu:20.04 | ||
ARG VARIANT | ||
ARG TARGETARCH | ||
ARG FRAMEWORK_VERSION=v2.15.14 | ||
|
||
FROM quay.io/kairos/kairos-init:v0.2.4 AS kairos-init | ||
FROM --platform="linux/${TARGETARCH}" quay.io/kairos/framework:${FRAMEWORK_VERSION} AS framework | ||
FROM quay.io/kairos/kairos-init:v0.2.6 AS kairos-init | ||
|
||
FROM ${BASE_IMAGE} AS base-kairos | ||
ARG VARIANT=core | ||
ARG MODEL=generic | ||
ARG TRUSTED_BOOT=false | ||
ARG KUBERNETES_DISTRO=k3s | ||
ARG KUBERNETES_VERSION=latest | ||
ARG FRAMEWORK_VERSION | ||
ARG FRAMEWORK_VERSION=v2.16.1 | ||
ARG VERSION | ||
|
||
COPY --from=kairos-init /kairos-init /kairos-init | ||
RUN /kairos-init -f "${FRAMEWORK_VERSION}" -l debug -s install -m "${MODEL}" -v "${VARIANT}" -t "${TRUSTED_BOOT}" -k "${KUBERNETES_DISTRO}" --k8sversion "${KUBERNETES_VERSION}" | ||
RUN /kairos-init -f "${FRAMEWORK_VERSION}" -l debug -s init -m "${MODEL}" -v "${VARIANT}" -t "${TRUSTED_BOOT}" -k "${KUBERNETES_DISTRO}" --k8sversion "${KUBERNETES_VERSION}" | ||
RUN /kairos-init -f "${FRAMEWORK_VERSION}" -l debug --validate -m "${MODEL}" -v "${VARIANT}" -t "${TRUSTED_BOOT}" -k "${KUBERNETES_DISTRO}" --k8sversion "${KUBERNETES_VERSION}" | ||
RUN rm /kairos-init | ||
|
||
FROM base-kairos AS kairos-core | ||
|
||
FROM base-kairos AS kairos-standard | ||
COPY --from=framework /usr/bin/luet /usr/bin/luet | ||
COPY --from=framework /etc/luet/luet.yaml /etc/luet/luet.yaml | ||
RUN luet install -y utils/edgevpn utils/k9s utils/nerdctl container/kubectl utils/kube-vip | ||
|
||
FROM kairos-${VARIANT} AS kairos-final | ||
RUN /kairos-init -f "${FRAMEWORK_VERSION}" -l debug -s install -m "${MODEL}" -v "${VARIANT}" -t "${TRUSTED_BOOT}" -k "${KUBERNETES_DISTRO}" --k8sversion "${KUBERNETES_VERSION}" --version "${VERSION}" | ||
RUN /kairos-init -f "${FRAMEWORK_VERSION}" -l debug -s init -m "${MODEL}" -v "${VARIANT}" -t "${TRUSTED_BOOT}" -k "${KUBERNETES_DISTRO}" --k8sversion "${KUBERNETES_VERSION}" --version "${VERSION}" | ||
RUN /kairos-init -f "${FRAMEWORK_VERSION}" -l debug --validate -m "${MODEL}" -v "${VARIANT}" -t "${TRUSTED_BOOT}" -k "${KUBERNETES_DISTRO}" --k8sversion "${KUBERNETES_VERSION}" --version "${VERSION}" | ||
RUN rm /kairos-init |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,7 +55,6 @@ var _ = Describe("k3s upgrade manual test", Label("upgrade-with-cli"), func() { | |
currentVersion, err := vm.Sudo(getVersionCmd) | ||
Expect(err).ToNot(HaveOccurred()) | ||
By(fmt.Sprintf("Checking current version: %s", currentVersion)) | ||
Expect(currentVersion).To(ContainSubstring("v")) | ||
|
||
By(fmt.Sprintf("Upgrading to: %s", containerImage)) | ||
out, err := vm.Sudo("kairos-agent --debug upgrade --force --source oci://" + containerImage) | ||
|
@@ -71,12 +70,6 @@ var _ = Describe("k3s upgrade manual test", Label("upgrade-with-cli"), func() { | |
return err | ||
}, 10*time.Minute, 10*time.Second).ShouldNot(HaveOccurred()) | ||
|
||
var v string | ||
Eventually(func() string { | ||
v, _ = vm.Sudo(getVersionCmd) | ||
return v | ||
// TODO: Add regex semver check here | ||
}, 10*time.Minute, 10*time.Second).Should(ContainSubstring("v"), v) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This check seemed intentional. What changed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. freeform semver for now. Still this check is useless. Checking that the version just contains a v its absurd? Even if the upgrade didnt pass, this check would pass so I dont see how this is a useful check at all. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we added that because we had a bug with a missing |
||
}) | ||
}) | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this happening on kairos-init now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kairos-io/kairos-init@29ac33a