Bump and adapt to new kairos-init #3214
Conversation
- fixes some issues with alpine - brings missing logrotate - installs expected utils in standard - now requires a version to be passes to set the output version of the artifacts Signed-off-by: Itxaka <itxaka@kairos.io>
Signed-off-by: Itxaka <itxaka@kairos.io>
Why would we check if there is a v in the version name? How does that checks if the upgrade went ok?? Signed-off-by: Itxaka <itxaka@kairos.io>
|
|
| FROM base-kairos AS kairos-standard | ||
| COPY --from=framework /usr/bin/luet /usr/bin/luet | ||
| COPY --from=framework /etc/luet/luet.yaml /etc/luet/luet.yaml | ||
| RUN luet install -y utils/edgevpn utils/k9s utils/nerdctl container/kubectl utils/kube-vip |
There was a problem hiding this comment.
is this happening on kairos-init now?
There was a problem hiding this comment.
| v, _ = vm.Sudo(getVersionCmd) | ||
| return v | ||
| // TODO: Add regex semver check here | ||
| }, 10*time.Minute, 10*time.Second).Should(ContainSubstring("v"), v) |
There was a problem hiding this comment.
This check seemed intentional. What changed?
There was a problem hiding this comment.
freeform semver for now.
Still this check is useless. Checking that the version just contains a v its absurd? Even if the upgrade didnt pass, this check would pass so I dont see how this is a useful check at all.
There was a problem hiding this comment.
I think we added that because we had a bug with a missing v . This covers it enough :D.
Signed-off-by: Itxaka <itxaka@kairos.io>
It's actually an issue with future alpine versions, as they removed /var/lock and linked it to /run/lock which breaks the locking mechanism of yip on user creation |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #