Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring SetupManager #948

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Refactoring SetupManager #948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab09b46
Refactoring SetupManager
kuritka Sep 5, 2022
817010c
Update controllers/gslb_controller_setup.go
kuritka Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
165 changes: 0 additions & 165 deletions controllers/gslb_controller.go → ...rollers/gslb_controller_reconciliation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ Generated by GoLic, for more details see: https://github.com/AbsaOSS/golic
import (
"context"
"fmt"
"strconv"

"github.com/k8gb-io/k8gb/controllers/providers/metrics"

Expand All @@ -32,19 +31,10 @@ import (
"github.com/k8gb-io/k8gb/controllers/providers/dns"
"go.opentelemetry.io/otel/codes"
"go.opentelemetry.io/otel/trace"
corev1 "k8s.io/api/core/v1"
netv1 "k8s.io/api/networking/v1"
"k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
types "k8s.io/apimachinery/pkg/types"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
"sigs.k8s.io/controller-runtime/pkg/handler"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
"sigs.k8s.io/controller-runtime/pkg/source"
externaldns "sigs.k8s.io/external-dns/endpoint"
)

// GslbReconciler reconciles a Gslb object
Expand Down Expand Up @@ -198,158 +188,3 @@ func (r *GslbReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.
m.IncrementReconciliation(gslb)
return result.Requeue()
}

// SetupWithManager configures controller manager
func (r *GslbReconciler) SetupWithManager(mgr ctrl.Manager) error {
// Figure out Gslb resource name to Reconcile when non controlled Name is updated

endpointMapHandler := handler.EnqueueRequestsFromMapFunc(
func(a client.Object) []reconcile.Request {
gslbList := &k8gbv1beta1.GslbList{}
opts := []client.ListOption{
client.InNamespace(a.GetNamespace()),
}
c := mgr.GetClient()
err := c.List(context.TODO(), gslbList, opts...)
if err != nil {
log.Info().Msg("Can't fetch gslb objects")
return nil
}
gslbName := ""
for _, gslb := range gslbList.Items {
for _, rule := range gslb.Spec.Ingress.Rules {
for _, path := range rule.HTTP.Paths {
if path.Backend.Service != nil && path.Backend.Service.Name == a.GetName() {
gslbName = gslb.Name
}
}
}
}
if len(gslbName) > 0 {
return []reconcile.Request{
{NamespacedName: types.NamespacedName{
Name: gslbName,
Namespace: a.GetNamespace(),
}},
}
}
return nil
})

createGslbFromIngress := func(annotationKey string, annotationValue string, a client.Object, strategy string) {
log.Info().
Str("annotation", fmt.Sprintf("(%s:%s)", annotationKey, annotationValue)).
Str("ingress", a.GetName()).
Msg("Detected strategy annotation on ingress")
c := mgr.GetClient()
ingressToReuse := &netv1.Ingress{}
err := c.Get(context.Background(), client.ObjectKey{
Namespace: a.GetNamespace(),
Name: a.GetName(),
}, ingressToReuse)
if err != nil {
log.Info().
Str("ingress", a.GetName()).
Msg("Ingress does not exist anymore. Skipping Glsb creation...")
return
}
gslbExist := &k8gbv1beta1.Gslb{}
err = c.Get(context.Background(), client.ObjectKey{
Namespace: a.GetNamespace(),
Name: a.GetName(),
}, gslbExist)
if err == nil {
log.Info().
Str("gslb", gslbExist.Name).
Msg("Gslb already exists. Skipping Gslb creation...")
return
}
gslb := &k8gbv1beta1.Gslb{
ObjectMeta: metav1.ObjectMeta{
Namespace: a.GetNamespace(),
Name: a.GetName(),
Annotations: a.GetAnnotations(),
},
Spec: k8gbv1beta1.GslbSpec{
Ingress: k8gbv1beta1.FromV1IngressSpec(ingressToReuse.Spec),
Strategy: k8gbv1beta1.Strategy{
Type: strategy,
},
},
}

annotationToInt := func(k string, v string) int {
intValue, err := strconv.Atoi(v)
if err != nil {
log.Err(err).
Str("annotationKey", k).
Str("annotationValue", v).
Msg("Can't parse annotation value to int")
}
return intValue
}

for annotationKey, annotationValue := range a.GetAnnotations() {
switch annotationKey {
case dnsTTLSecondsAnnotation:
gslb.Spec.Strategy.DNSTtlSeconds = annotationToInt(annotationKey, annotationValue)
case splitBrainThresholdSecondsAnnotation:
gslb.Spec.Strategy.SplitBrainThresholdSeconds = annotationToInt(annotationKey, annotationValue)
}
}

if strategy == depresolver.FailoverStrategy {
for annotationKey, annotationValue := range a.GetAnnotations() {
if annotationKey == primaryGeoTagAnnotation {
gslb.Spec.Strategy.PrimaryGeoTag = annotationValue
}
}
if gslb.Spec.Strategy.PrimaryGeoTag == "" {
log.Info().
Str("annotation", primaryGeoTagAnnotation).
Str("gslb", gslb.Name).
Msg("Annotation is missing, skipping Gslb creation...")
return
}
}

err = controllerutil.SetControllerReference(ingressToReuse, gslb, r.Scheme)
if err != nil {
log.Err(err).
Str("ingress", ingressToReuse.Name).
Str("gslb", gslb.Name).
Msg("Cannot set the Ingress as the owner of the Gslb")
}

log.Info().
Str("gslb", gslb.Name).
Msg("Creating new Gslb out of Ingress annotation")
err = c.Create(context.Background(), gslb)
if err != nil {
log.Err(err).Msg("Glsb creation failed")
}
}

ingressMapHandler := handler.EnqueueRequestsFromMapFunc(
func(a client.Object) []reconcile.Request {
for annotationKey, annotationValue := range a.GetAnnotations() {
if annotationKey == strategyAnnotation {
switch annotationValue {
case depresolver.RoundRobinStrategy:
createGslbFromIngress(annotationKey, annotationValue, a, depresolver.RoundRobinStrategy)
case depresolver.FailoverStrategy:
createGslbFromIngress(annotationKey, annotationValue, a, depresolver.FailoverStrategy)
}
}
}
return nil
})

return ctrl.NewControllerManagedBy(mgr).
For(&k8gbv1beta1.Gslb{}).
Owns(&netv1.Ingress{}).
Owns(&externaldns.DNSEndpoint{}).
Watches(&source.Kind{Type: &corev1.Endpoints{}}, endpointMapHandler).
Watches(&source.Kind{Type: &netv1.Ingress{}}, ingressMapHandler).
Complete(r)
}
0 controllers/gslb_controller_test.go → ...rs/gslb_controller_reconciliation_test.go
View file
Open in desktop
File renamed without changes.
197 changes: 197 additions & 0 deletions controllers/gslb_controller_setup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,197 @@
package controllers

/*
Copyright 2022 The k8gb Contributors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

Generated by GoLic, for more details see: https://github.com/AbsaOSS/golic
*/

import (
"context"
"fmt"
"strconv"

"github.com/k8gb-io/k8gb/controllers/depresolver"

k8gbv1beta1 "github.com/k8gb-io/k8gb/api/v1beta1"
corev1 "k8s.io/api/core/v1"
netv1 "k8s.io/api/networking/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
"sigs.k8s.io/controller-runtime/pkg/handler"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
"sigs.k8s.io/controller-runtime/pkg/source"
externaldns "sigs.k8s.io/external-dns/endpoint"
)

// SetupWithManager configures controller manager
func (r *GslbReconciler) SetupWithManager(mgr ctrl.Manager) error {
// Figure out Gslb resource name to Reconcile when non controlled Name is updated

endpointMapHandler := handler.EnqueueRequestsFromMapFunc(
func(a client.Object) []reconcile.Request {
gslbList := &k8gbv1beta1.GslbList{}
opts := []client.ListOption{
client.InNamespace(a.GetNamespace()),
}
c := mgr.GetClient()
err := c.List(context.TODO(), gslbList, opts...)
if err != nil {
log.Info().Msg("Can't fetch gslb objects")
return nil
}
gslbName := ""
for _, gslb := range gslbList.Items {
for _, rule := range gslb.Spec.Ingress.Rules {
for _, path := range rule.HTTP.Paths {
if path.Backend.Service != nil && path.Backend.Service.Name == a.GetName() {
gslbName = gslb.Name
}
}
}
}
if len(gslbName) > 0 {
return []reconcile.Request{
{NamespacedName: types.NamespacedName{
Name: gslbName,
Namespace: a.GetNamespace(),
}},
}
}
return nil
})

ingressMapHandler := handler.EnqueueRequestsFromMapFunc(
func(a client.Object) []reconcile.Request {
annotations := a.GetAnnotations()
if annotationValue, found := annotations[strategyAnnotation]; found {
c := mgr.GetClient()
r.createGSLBFromIngress(c, a, annotationValue)
}
return nil
})

return ctrl.NewControllerManagedBy(mgr).
For(&k8gbv1beta1.Gslb{}).
Owns(&netv1.Ingress{}).
Owns(&externaldns.DNSEndpoint{}).
Watches(&source.Kind{Type: &corev1.Endpoints{}}, endpointMapHandler).
Watches(&source.Kind{Type: &netv1.Ingress{}}, ingressMapHandler).
Complete(r)
}

func (r *GslbReconciler) createGSLBFromIngress(c client.Client, a client.Object, strategy string) {
log.Info().
Str("annotation", fmt.Sprintf("(%s:%s)", strategyAnnotation, strategy)).
Str("ingress", a.GetName()).
Msg("Detected strategy annotation on ingress")

ingressToReuse := &netv1.Ingress{}
err := c.Get(context.Background(), client.ObjectKey{
Namespace: a.GetNamespace(),
Name: a.GetName(),
}, ingressToReuse)
if err != nil {
log.Info().
Str("ingress", a.GetName()).
Msg("Ingress does not exist anymore. Skipping Glsb creation...")
return
}
gslbExist := &k8gbv1beta1.Gslb{}
err = c.Get(context.Background(), client.ObjectKey{
Namespace: a.GetNamespace(),
Name: a.GetName(),
}, gslbExist)
if err == nil {
log.Info().
Str("gslb", gslbExist.Name).
Msg("Gslb already exists. Skipping Gslb creation...")
return
}
gslb := &k8gbv1beta1.Gslb{
ObjectMeta: metav1.ObjectMeta{
Namespace: a.GetNamespace(),
Name: a.GetName(),
Annotations: a.GetAnnotations(),
},
Spec: k8gbv1beta1.GslbSpec{
Ingress: k8gbv1beta1.FromV1IngressSpec(ingressToReuse.Spec),
},
}

gslb.Spec.Strategy, err = r.parseStrategy(a.GetAnnotations(), strategy)
if err != nil {
log.Err(err).
Str("gslb", gslbExist.Name).
Msg("can't parse Gslb strategy")
return
}

err = controllerutil.SetControllerReference(ingressToReuse, gslb, r.Scheme)
if err != nil {
log.Err(err).
Str("ingress", ingressToReuse.Name).
Str("gslb", gslb.Name).
Msg("Cannot set the Ingress as the owner of the Gslb")
}

log.Info().
Str("gslb", gslb.Name).
Msg(fmt.Sprintf("Creating a new Gslb out of Ingress with '%s' annotation", strategyAnnotation))
err = c.Create(context.Background(), gslb)
if err != nil {
log.Err(err).Msg("Glsb creation failed")
}
}

func (r *GslbReconciler) parseStrategy(annotations map[string]string, strategy string) (result k8gbv1beta1.Strategy, err error) {
toInt := func(k string, v string) (int, error) {
intValue, err := strconv.Atoi(v)
if err != nil {
return -1, fmt.Errorf("can't parse annotation value %s to int for key %s", v, k)
}
return intValue, nil
}

result = k8gbv1beta1.Strategy{
Type: strategy,
}

for annotationKey, annotationValue := range annotations {
switch annotationKey {
case dnsTTLSecondsAnnotation:
if result.DNSTtlSeconds, err = toInt(annotationKey, annotationValue); err != nil {
return result, err
}
case splitBrainThresholdSecondsAnnotation:
if result.SplitBrainThresholdSeconds, err = toInt(annotationKey, annotationValue); err != nil {
return result, err
}
case primaryGeoTagAnnotation:
result.PrimaryGeoTag = annotationValue
}
}

if strategy == depresolver.FailoverStrategy {
if len(result.PrimaryGeoTag) == 0 {
return result, fmt.Errorf("%s strategy requires annotation %s", depresolver.FailoverStrategy, primaryGeoTagAnnotation)
}
}

return result, nil
}
Loading