Refactoring SetupManager #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
k0da,
somaritane,
ytsarev and
jkremser
as code owners
jkremser
requested changes
Sep 5, 2022
controllers/gslb_controller_setup.go
Outdated
|
|
||
| log.Info(). | ||
| Str("gslb", gslb.Name). | ||
| Msg("Creating new Gslb out of Ingress annotation") |
There was a problem hiding this comment.
nit: I know there was no change in this msg, but can we put here:
"Creating a new Gslb out of Ingress with 'k8gb.io/strategy' annotation" (we don't care about ingresses that don't have this annotation)
(k8gb.io/strategy == strategyAnnotation)
controllers/gslb_controller_setup.go
Outdated
|
|
||
| if strategy == depresolver.FailoverStrategy { | ||
| if len(result.PrimaryGeoTag) == 0 { | ||
| return result, fmt.Errorf("%s strategy requires annotation", depresolver.FailoverStrategy) |
There was a problem hiding this comment.
This will print:
"failover strategy requires annotation" which is not very helpful imho
can we put here
"failover strategy requires annotation k8gb.io/primary-geotag to be also present on the Ingress resource"
(primaryGeoTagAnnotation == k8gb.io/primary-geotag)
related to #932 The setup manager is quite complex. We are currently solving a bug related to the fact that changes in ingress also change the GSLB and can cause cycles #932. I am doing the necessary refactoring (code is better structured, but the functionality remains the same), to make it easier to make the necessary changes.. - split SetupWithManager and Reconciliation into two files - encapsulate createGslbFromIngress - simplify ingressHandler - extracting parse strategy func Signed-off-by: kuritka <kuritka@gmail.com>
kuritka
force-pushed
the
refactor-setup
branch
from
560efef to
ab09b46
Compare
jkremser
reviewed
Sep 6, 2022
Co-authored-by: Jirka Kremser <535866+jkremser@users.noreply.github.com> Signed-off-by: MichalK <kuritka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #932
The setup manager is quite complex. We are currently solving a bug related to the fact that changes in ingress also change the GSLB and can cause cycles #932. I am doing the necessary refactoring (code is better structured, but the functionality remains the same), to make it easier to fix #932.
Signed-off-by: kuritka kuritka@gmail.com