Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy test-gslb namespace only in local cluster #738

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Deploy test-gslb namespace only in local cluster #738

merged 1 commit into from
Nov 16, 2021

Conversation

k0da
Copy link
Collaborator

@k0da k0da commented Nov 15, 2021

We don't really need podinfo during terratest run in pipelines. To save
up some compute resources and CI run time.

Signed-off-by: Dinar Valeev dinar.valeev@absa.africa

@k0da
Deploy test-gslb namespace only in local cluster
eb024b1 
We don't really need podinfo during terratest run in pipelines. To save
up some compute resources and CI run time.

Signed-off-by: Dinar Valeev <dinar.valeev@absa.africa>
ytsarev
ytsarev reviewed Nov 16, 2021
View reviewed changes
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify - we actually need podinfo but it is getting deployed by terratest itself into the dynamically created namespace, correct?

@k0da
Copy link
Collaborator Author

k0da commented Nov 16, 2021

Yes, deploy-test-app moved to deploy-full-local-setup. Terratesst helm installs podinfo on its own

@k0da k0da merged commit 35982b6 into master Nov 16, 2021
@k0da k0da deleted the nopodinfo branch November 16, 2021 15:53
@somaritane somaritane mentioned this pull request Nov 16, 2021
Closed
somaritane added a commit that referenced this pull request Nov 16, 2021
@somaritane
fix: Broken first user experience commands
a82481d 
Fixes broken user experience after #738 merge:
- call to `deploy-test-apps` function fixed in `deploy-full-cluster-setup` target
- deploy-test-apps function uses default k8s context for empty cluster arg

Fixes #751

Signed-off-by: Timofey Ilinykh <ilinytim@gmail.com>
@somaritane somaritane mentioned this pull request Nov 16, 2021
Merged
somaritane pushed a commit that referenced this pull request Nov 16, 2021
fix: Broken first user experience commands (#752)
231834f 
Fixes broken user experience after #738 merge:
- call to `deploy-test-apps` function fixed in `deploy-full-local-setup` target
- `deploy-test-apps` function uses default k8s context for empty cluster arg

Fixes #751

Signed-off-by: Timofey Ilinykh <ilinytim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytsarev ytsarev ytsarev approved these changes

@donovanmuller donovanmuller Awaiting requested review from donovanmuller donovanmuller is a code owner

@jkremser jkremser Awaiting requested review from jkremser jkremser is a code owner

@kuritka kuritka Awaiting requested review from kuritka kuritka is a code owner

@somaritane somaritane Awaiting requested review from somaritane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k0da @ytsarev