Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy-test-apps and deploy-full-local-setup make commands are broken #751

Closed
somaritane opened this issue Nov 16, 2021 · 0 comments · Fixed by #752
Closed

deploy-test-apps and deploy-full-local-setup make commands are broken #751

somaritane opened this issue Nov 16, 2021 · 0 comments · Fixed by #752
Assignees
Labels
bug Something isn't working

Comments

@somaritane
Copy link
Contributor

First user experience commands (make deploy-test-apps and make deploy-full-local-setup) are broken after #738 merge:

    $ make deploy-full-local-setup
    ...
    Deploy test apps
    kubectl config use-context k3d- test-gslb1
    Set the current-context in a kubeconfig file.

    Aliases:
    use-context, use

    Examples:
    # Use the context for the minikube cluster
    kubectl config use-context minikube

    Usage:
    kubectl config use-context CONTEXT_NAME [options]

    Use "kubectl options" for a list of global command-line options (applies to all commands).
    error: Unexpected args: [k3d- test-gslb1]
    make: *** [deploy-full-local-setup] Error 1
    $ make deploy-test-apps
    ...
    Deploy test apps
    kubectl config use-context k3d-
    Set the current-context in a kubeconfig file.

    Aliases:
    use-context, use

    Examples:
    # Use the context for the minikube cluster
    kubectl config use-context minikube

    Usage:
    kubectl config use-context CONTEXT_NAME [options]

    Use "kubectl options" for a list of global command-line options (applies to all commands).
    error: Unexpected args: [k3d- test-gslb1]
    make: *** [deploy-test-apps] Error 1
@somaritane somaritane added the bug Something isn't working label Nov 16, 2021
somaritane added a commit that referenced this issue Nov 16, 2021
Fixes broken user experience after #738 merge:
- call to `deploy-test-apps` function fixed in `deploy-full-cluster-setup` target
- deploy-test-apps function uses default k8s context for empty cluster arg

Fixes #751

Signed-off-by: Timofey Ilinykh <ilinytim@gmail.com>
somaritane pushed a commit that referenced this issue Nov 16, 2021
Fixes broken user experience after #738 merge:
- call to `deploy-test-apps` function fixed in `deploy-full-local-setup` target
- `deploy-test-apps` function uses default k8s context for empty cluster arg

Fixes #751

Signed-off-by: Timofey Ilinykh <ilinytim@gmail.com>
@somaritane somaritane self-assigned this Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant