Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRUD gslb zone delegation in infoblox #39

Merged
merged 6 commits into from
Feb 2, 2020
Merged

CRUD gslb zone delegation in infoblox #39

merged 6 commits into from
Feb 2, 2020

Commits on Jan 31, 2020

  1. Create and Update delegated zone during reconciliation 

    * Use Absa fork of official infoblox go client until we
  merge changes(ZoneDelegated CRUD) upstream
* Dedicated Zone handling function
* Configmap and values for infoblox related data
    @ytsarev
    ytsarev committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    b512de9 View commit details
    Browse the repository at this point in the history

  2. Obey errcheck 

    * kisielk/errcheck#55 (comment)
    @ytsarev
    ytsarev committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    8a125a2 View commit details
    Browse the repository at this point in the history

  3. Add finalizer to cleanup delegated zone on deletion 

    * Relies on https://kubernetes.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definitions/#finalizers
* Reuses logic from https://github.com/operator-framework/operator-sdk/blob/master/doc/user-guide.md#handle-cleanup-on-deletion
* E2E tested
    @ytsarev
    ytsarev committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    6c6bbc6 View commit details
    Browse the repository at this point in the history

  4. Bump version

    @ytsarev
    ytsarev committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    26b0a5d View commit details
    Browse the repository at this point in the history

  5. Catch error on zone deletion

    @ytsarev
    ytsarev committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    f001412 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2020

  1. Fix alien infoblox ref problem 

    * Use fixed ibclient which does not return first ref from the
  array when requested fqdn is blank
* Additional safety net with checking matching fqdns from returned
  infoblox objects
* Inline reconciliation fix
    @ytsarev
    ytsarev committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    8cf2605 View commit details
    Browse the repository at this point in the history