CRUD gslb zone delegation in infoblox #39

ytsarev · 2020-01-31T17:54:23Z

Create/Update zone during reconciliation if infoblox is enabled
Delete on gslb deletion with the help of https://kubernetes.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definitions/#finalizers
Code is only e2e tested, we might want to invest into mocking infoblox out in unit tests later on

* Use Absa fork of official infoblox go client until we merge changes(ZoneDelegated CRUD) upstream * Dedicated Zone handling function * Configmap and values for infoblox related data

* kisielk/errcheck#55 (comment)

* Relies on https://kubernetes.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definitions/#finalizers * Reuses logic from https://github.com/operator-framework/operator-sdk/blob/master/doc/user-guide.md#handle-cleanup-on-deletion * E2E tested

* Use fixed ibclient which does not return first ref from the array when requested fqdn is blank * Additional safety net with checking matching fqdns from returned infoblox objects * Inline reconciliation fix

ytsarev added 4 commits January 31, 2020 16:38

Create and Update delegated zone during reconciliation

b512de9

* Use Absa fork of official infoblox go client until we merge changes(ZoneDelegated CRUD) upstream * Dedicated Zone handling function * Configmap and values for infoblox related data

Obey errcheck

8a125a2

* kisielk/errcheck#55 (comment)

Bump version

26b0a5d

ytsarev requested a review from donovanmuller January 31, 2020 17:54

Catch error on zone deletion

f001412

donovanmuller approved these changes Jan 31, 2020

View reviewed changes

Fix alien infoblox ref problem

8cf2605

* Use fixed ibclient which does not return first ref from the array when requested fqdn is blank * Additional safety net with checking matching fqdns from returned infoblox objects * Inline reconciliation fix

ytsarev force-pushed the delegate branch from 85d3ca3 to 8cf2605 Compare February 2, 2020 02:12

ytsarev requested a review from donovanmuller February 2, 2020 03:25

donovanmuller approved these changes Feb 2, 2020

View reviewed changes

ytsarev merged commit 3ed9173 into master Feb 2, 2020

ytsarev deleted the delegate branch February 2, 2020 09:54

ytsarev mentioned this pull request Apr 23, 2020

Document internal components of k8gb #89

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CRUD gslb zone delegation in infoblox #39

CRUD gslb zone delegation in infoblox #39

ytsarev commented Jan 31, 2020

CRUD gslb zone delegation in infoblox #39

CRUD gslb zone delegation in infoblox #39

Conversation

ytsarev commented Jan 31, 2020