Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.22] Fix rancher traefik upgrade suggestion #4325

Merged

Conversation

brandond
Copy link
Member

@brandond brandond commented Oct 26, 2021

Proposed Changes

Add dashboard annotation to the Traefik helm chart to prevent Rancher from suggesting upgrades to it.

The 'hidden' annotation only works on charts in the repo, not ones installed to the cluster. This makes it show as 'Managed' in the UI.

Types of Changes

bugfix

Verification

Import K3s cluster into Rancher or install Rancher on K3s. Note that it no longer suggests upgrading the packaged Traefik.

Linked Issues

User-Facing Change

Rancher will no longer suggest upgrading the Traefik chart packaged with K3s.

Further Comments

@brandond brandond requested a review from a team as a code owner October 26, 2021 00:31
@brandond brandond marked this pull request as draft October 26, 2021 02:10
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond force-pushed the fix_rancher_traefik_upgrade_release-1.22 branch from 634f554 to b136d70 Compare October 27, 2021 05:00
@brandond brandond marked this pull request as ready for review October 27, 2021 05:07
@codecov-commenter
Copy link

Codecov Report

Merging #4325 (b136d70) into release-1.22 (c9f6fa0) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           release-1.22    #4325      +/-   ##
================================================
- Coverage         11.18%   11.18%   -0.01%     
================================================
  Files               135      135              
  Lines              9292     9293       +1     
================================================
  Hits               1039     1039              
- Misses             8035     8036       +1     
  Partials            218      218              
Flag Coverage Δ
inttests 0.32% <ø> (-0.01%) ⬇️
unittests 11.18% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/static/zz_generated_bindata.go 0.00% <ø> (ø)
pkg/cluster/https.go 0.00% <0.00%> (ø)
pkg/cluster/bootstrap.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9f6fa0...b136d70. Read the comment docs.

@brandond brandond merged commit 38cf9a3 into k3s-io:release-1.22 Nov 11, 2021
@brandond brandond deleted the fix_rancher_traefik_upgrade_release-1.22 branch June 6, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants