Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect packaged helm charts from upgrade via Rancher UI #4315

Closed
brandond opened this issue Oct 23, 2021 · 2 comments
Closed

Protect packaged helm charts from upgrade via Rancher UI #4315

brandond opened this issue Oct 23, 2021 · 2 comments
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@brandond
Copy link
Member

brandond commented Oct 23, 2021

The Rancher UI currently suggests upgrades and allows edits of Helm charts for packaged components. We should protect these charts so that they cannot be edited via the Rancher UI, and it does not suggest upgrades if a matching chart name is found in a chart repo.

As per @vincent99 we could do this by setting an annotation in the Helm release data:
https://github.com/rancher/rancher/issues/35256#issuecomment-950018715

We should confirm with the Rancher team that this is the correct and best way to do this, and then figure out how to do so. A Helm plugin (similar to what we did for helm-set-status) may be the easiest thing to do?

@rancher-max
Copy link
Contributor

Have not fully validated yet on master branch (slated for k8s 1.23), but will do that when the PR is merged and then close this issue. I opened a backport for 1.22 which I closed with comments and linked to the PR that fixes it, and will move this milestone to 1.23.

@rancher-max
Copy link
Contributor

Validated on master branch commitid 2f3bfc27c094ed81a2faf1e06e302e403ab9eab0

  • Confirmed traefik chart version is 10.3.001
  • Confirmed no upgrade shown in rancher UI on both fresh installs and upgrades
  • Confirmed it shows Managed on rancher UI on fresh installs and after an upgrade:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants