Fix / choose offer modal without prices #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit bc8389e): https://ottwebapp--pr313-fix-choose-offer-mod-kp6tvhfn.web.app (expires Thu, 13 Jul 2023 13:25:37 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
kiremitrov123
requested review from
ChristiaanScheermeijer,
AntonLantukh and
darkoatanasovski
darkoatanasovski
approved these changes
Jun 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Choose offer modal improvements so that when someone tries to pay a tvod item and therefore the item doesn't have prices set up, we show them message that there are no prices instead of not doing anything despite clicking the buy button.
Here is an example how it looks now and you can navigate to the subscription prices and back, but you will not be able to continue with the flow for the TVOD item since it doesn't have prices the button for continue is disabled.
This PR solves # .
Steps completed:
According to our definition of done, I have completed the following steps: