Fix / checkout issues #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristiaanScheermeijer
requested review from
dbudzins,
AntonLantukh and
kiremitrov123
|
Visit the preview URL for this PR (updated for commit afc09b7): https://ottwebapp--pr312-fix-checkout-issues-bydwdvyk.web.app (expires Wed, 12 Jul 2023 09:11:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
AntonLantukh
approved these changes
Jun 12, 2023
8 tasks
|
@AntonLantukh @kiremitrov123 if we merge this PR, we don't need to change the target branch in #313 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two problems. The first problem was an infinite render loop when opening the choose offers modal. This was caused by using a default value as react-query data. This becomes an issue when the same variable becomes a dependency in a useEffect/useMemo.
The second change fixes a React hook violation. This probably wasn't an issue before because it didn't use any hooks internally, but we've added a
useMemohook to ... ironically ... also prevent infinite render loops.