-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo3 13 compatibility #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enforce TYPO3 13.4.0 LTS as minimmal version and additionally ensure PHP versions. Used command(s): ```shell composer require \ "typo3/cms-core":"^13.4" \ "php":"^8.2" ```
This change aligns the PHP version support for the `Build/Scripts/runTests.sh` dispatcher script to the version range of supported TYPO3 versions and set `8.2` as new default PHP version. Github action workflow file is adjusted along the way.
…eUid()` Repository method `AvalexConfigurationRepository->findByRootPageUid()` builds a conditinal based query using `inSet()` or a direct value filtering and requires a prioritized ordering to retrieve the wanted record as first record. Different database vendors has different requirements which requires to compose sql queries precisly and in a deterministic way. This change ... * Avoids `named parameters` for the `inSet()` filter, which does not work properly for all database vendors by using the value direct. * Reuse the `inSet()` filter as first sorting criteria (1st level) to reflect the matched state as highes priority records, keeping the `global` ordering as second level. * Adds `uid` as last sorting criteria (3rd) level to take care of a deterministic sorting in case 1st and 2nd level produces multiple records to avoid randomized query result retrieval.
[BUGFIX] Ensure working `AvalexConfigurationRepository->findByRootPageUid()`
hojalatheef
reviewed
Jan 7, 2025
hojalatheef
reviewed
Jan 7, 2025
hojalatheef
reviewed
Jan 8, 2025
hojalatheef
reviewed
Jan 8, 2025
hojalatheef
reviewed
Jan 8, 2025
hojalatheef
reviewed
Jan 8, 2025
hojalatheef
reviewed
Jan 8, 2025
hojalatheef
reviewed
Jan 8, 2025
hojalatheef
reviewed
Jan 8, 2025
hojalatheef
reviewed
Jan 8, 2025
hojalatheef
reviewed
Jan 8, 2025
hojalatheef
reviewed
Jan 8, 2025
hojalatheef
reviewed
Jan 8, 2025
hojalatheef
reviewed
Jan 8, 2025
hojalatheef
reviewed
Jan 8, 2025
hojalatheef
reviewed
Jan 8, 2025
hojalatheef
reviewed
Jan 8, 2025
hojalatheef
reviewed
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sfroemkenjw
Please take a look on the review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.