Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo3 13 compatibility #46

Merged
merged 36 commits into from
Jan 8, 2025
Merged

Typo3 13 compatibility #46

merged 36 commits into from
Jan 8, 2025

Conversation

sfroemkenjw
Copy link
Contributor

No description provided.

sfroemkenjw and others added 26 commits December 20, 2024 11:58
Enforce TYPO3 13.4.0 LTS as minimmal version and additionally
ensure PHP versions.

Used command(s):

```shell
composer require \
  "typo3/cms-core":"^13.4" \
  "php":"^8.2"
```
This change aligns the PHP version support for the
`Build/Scripts/runTests.sh` dispatcher script to
the version range of supported TYPO3 versions and
set `8.2` as new default PHP version.

Github action workflow file is adjusted along the
way.
…eUid()`

Repository method `AvalexConfigurationRepository->findByRootPageUid()`
builds a conditinal based query using `inSet()` or a direct value
filtering and requires a prioritized ordering to retrieve the wanted
record as first record.

Different database vendors has different requirements which requires
to compose sql queries precisly and in a deterministic way.

This change ...

*   Avoids `named parameters` for the `inSet()` filter, which does not
    work properly for all database vendors by using the value direct.
*   Reuse the `inSet()` filter as first sorting criteria (1st level) to
    reflect the matched state as highes priority records, keeping the
    `global` ordering as second level.
*   Adds `uid` as last sorting criteria (3rd) level to take care of a
    deterministic sorting in case 1st and 2nd level produces multiple
    records to avoid randomized query result retrieval.
[BUGFIX] Ensure working `AvalexConfigurationRepository->findByRootPageUid()`
Copy link

@hojalatheef hojalatheef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sfroemkenjw
Please take a look on the review comments.

@sfroemkenjw sfroemkenjw merged commit 58d0ee9 into main Jan 8, 2025
3 checks passed
@sfroemkenjw sfroemkenjw deleted the typo3_13_compatibility branch January 8, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants