[BUGFIX] Ensure working AvalexConfigurationRepository->findByRootPageUid()
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enforce TYPO3 13.4.0 LTS as minimmal version and additionally ensure PHP versions. Used command(s): ```shell composer require \ "typo3/cms-core":"^13.4" \ "php":"^8.2" ```
This change aligns the PHP version support for the `Build/Scripts/runTests.sh` dispatcher script to the version range of supported TYPO3 versions and set `8.2` as new default PHP version. Github action workflow file is adjusted along the way.
…eUid()`
Repository method `AvalexConfigurationRepository->findByRootPageUid()`
builds a conditinal based query using `inSet()` or a direct value
filtering and requires a prioritized ordering to retrieve the wanted
record as first record.
Different database vendors has different requirements which requires
to compose sql queries precisly and in a deterministic way.
This change ...
* Avoids `named parameters` for the `inSet()` filter, which does not
work properly for all database vendors by using the value direct.
* Reuse the `inSet()` filter as first sorting criteria (1st level) to
reflect the matched state as highes priority records, keeping the
`global` ordering as second level.
* Adds `uid` as last sorting criteria (3rd) level to take care of a
deterministic sorting in case 1st and 2nd level produces multiple
records to avoid randomized query result retrieval.
sfroemkenjw
merged commit 978ae5a
into
jweiland-net:typo3_13_compatibility
0 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[TASK] Use correct TYPO3 v13 LTS version as minimal constraint
Enforce TYPO3 13.4.0 LTS as minimmal version and additionally
ensure PHP versions.
Used command(s):
[TASK] Align php version support of
Build/Scripts/runTests.shThis change aligns the PHP version support for the
Build/Scripts/runTests.shdispatcher script tothe version range of supported TYPO3 versions and
set
8.2as new default PHP version.Github action workflow file is adjusted along the
way.
[BUGFIX] Ensure working
AvalexConfigurationRepository->findByRootPageUid()Repository method
AvalexConfigurationRepository->findByRootPageUid()builds a conditinal based query using
inSet()or a direct valuefiltering and requires a prioritized ordering to retrieve the wanted
record as first record.
Different database vendors has different requirements which requires
to compose sql queries precisly and in a deterministic way.
This change ...
named parametersfor theinSet()filter, which does notwork properly for all database vendors by using the value direct.
inSet()filter as first sorting criteria (1st level) toreflect the matched state as highes priority records, keeping the
globalordering as second level.uidas last sorting criteria (3rd) level to take care of adeterministic sorting in case 1st and 2nd level produces multiple
records to avoid randomized query result retrieval.