Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace call to print with logging.debug #2

Merged
merged 1 commit into from
Sep 8, 2015

Conversation

tinnet
Copy link
Contributor

@tinnet tinnet commented Sep 6, 2015

quick fix for py3 compatibility :)

@jvanasco
Copy link
Owner

jvanasco commented Sep 6, 2015

Wow. That should have been a debug for other reasons too. Thanks for catching. Will approve and bump a new release Monday or Tuesday.

On Sep 6, 2015, at 3:07 PM, Martin Contento notifications@github.com wrote:

quick fix for py3 compatibility :)

You can view, comment on, or merge this pull request online at:

#2

Commit Summary

replace call to print with logging.debug
File Changes

M pyramid_debugtoolbar_dogpile/init.py (2)
Patch Links:

https://github.com/jvanasco/pyramid_debugtoolbar_dogpile/pull/2.patch
https://github.com/jvanasco/pyramid_debugtoolbar_dogpile/pull/2.diff

Reply to this email directly or view it on GitHub.

@tinnet
Copy link
Contributor Author

tinnet commented Sep 7, 2015

Cool, thanks for getting a new version out quickly, I hate having -e git:/ lines in my requirements files :)

On another note: I tried to make the most minimal change possible here, but if you are interested I can follow it up with a PR that goes over the various pylint warnings in the project?

jvanasco added a commit that referenced this pull request Sep 8, 2015
replace call to print with logging.debug
@jvanasco jvanasco merged commit f6ae7aa into jvanasco:master Sep 8, 2015
@jvanasco
Copy link
Owner

jvanasco commented Sep 8, 2015

This is merged into the 0.0.5 tag and release on pypi (09/08/2015, 11:04am est)

what sort of warnings are you seeing in pylint that worry you? this passes my flake8 checks -- though I have a handful of settings regarding line length and bracket formatting turned off.

@tinnet
Copy link
Contributor Author

tinnet commented Sep 8, 2015

thanks! :)

most of the warnings are about the single letter variable names I think (i'm at the non-python day job right now, can't check). But if you are not bothered -> let's not touch a running system :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants