Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill the subprocess if it does not stop #88

Merged
merged 1 commit into from
May 8, 2020
Merged

Kill the subprocess if it does not stop #88

merged 1 commit into from
May 8, 2020

Conversation

blink1073
Copy link
Contributor

Our WatchHelper subprocesses were not responding to SIGTERM

afshin
afshin approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afshin afshin merged commit 51ab2e9 into jupyterlab:master May 8, 2020
@jasongrout
Copy link
Contributor

Thank you very much for figuring this out and fixing it!

@blink1073
Copy link
Contributor Author

@meeseeksdev please backport to 1.0.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab_server that referenced this pull request May 8, 2020
@afshin @meeseeksmachine
Backport PR jupyterlab#88: Kill the subprocess if it does not stop
6562f8b
@meeseeksmachine meeseeksmachine mentioned this pull request May 8, 2020
Merged
blink1073 pushed a commit that referenced this pull request May 8, 2020
@meeseeksmachine @afshin
Backport PR #88: Kill the subprocess if it does not stop (#89)
857c050 
Co-authored-by: Afshin Taylor Darian <git@darian.af>
This was referenced May 13, 2020
Merged
Merged
@telamonian
Copy link
Member

Do we know exactly why WatchHelper suddenly stopped exiting cleanly? All of a sudden I had to start chasing down and kill <pid>-ing a bunch of node processes whenever I launched jupyter lab --watch. My original sense was this was due to some change in a point release of webpack.

It's not essential, but it would be good to know the root cause in case eg we're missing some cleanup step somewhere for webpack.

@blink1073
Copy link
Contributor Author

I'm doing some exploration right now, see: #91 and jupyterlab/jupyterlab#8433. This issue is very hard to debug, despite years of experience dealing with subprocesses...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afshin afshin afshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blink1073 @jasongrout @telamonian @afshin