Backport PR #88: Kill the subprocess if it does not stop (#89)

Co-authored-by: Afshin Taylor Darian <git@darian.af>
jupyterlab · May 8, 2020 · 857c050 · 857c050
1 parent 64965eb
commit 857c050
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/jupyterlab_server/process.py b/jupyterlab_server/process.py
@@ -119,7 +119,12 @@ def terminate(self):
 
         # Wait for the process to close.
         try:
-            proc.wait()
+            proc.wait(timeout=1.)
+        except TimeoutError:
+            if os.name == 'nt':
+                os.kill(proc.pid, signal.SIGBREAK)
+            else:
+                os.kill(proc.pid, signal.SIGKILL)
         finally:
             Process._procs.remove(self)