Fall back to DEFAULT_LOCALE
when translation settings schema is invalid in get_current_locale
#207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to fix final CI bug for jupyterlab/jupyterlab#10929. Essentially, this PR restores the pre-#205 behavior by which a missing or malformed translation settings schema would result in
get_current_locale
returningDEFAULT_LOCALE
. This PR also slightly improves said old behavior by producing an informative warning when this happens, instead of being silent like before.Tested locally, fixes the problem.
pinging @fcollonval, @blink1073