Fall back to DEFAULT_LOCALE when translation settings schema is invalid in get_current_locale
#207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
==========================================
- Coverage 77.30% 77.06% -0.24%
==========================================
Files 28 28
Lines 2058 2067 +9
==========================================
+ Hits 1591 1593 +2
- Misses 467 474 +7
Continue to review full report at Codecov.
|
…settings schema is not valid - needed to fix final CI bug for jupyterlab/jupyterlab#10929
telamonian
force-pushed
the
add-fallback-to-get-locale
branch
from
8c4589c
to
5d66489
Compare
fcollonval
reviewed
Sep 8, 2021
| except web.HTTPError as e: | ||
| # fallback in case of missing (404) or misshapen (500) translation schema | ||
| locale = DEFAULT_LOCALE | ||
| 'Failed loading or validating translation settings schema' |
There was a problem hiding this comment.
@telamonian Should this be wrapped in self.log.warn? Is it needed to handle the error here even with the handling of the error within get_current_locale?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to fix final CI bug for jupyterlab/jupyterlab#10929. Essentially, this PR restores the pre-#205 behavior by which a missing or malformed translation settings schema would result in
get_current_localereturningDEFAULT_LOCALE. This PR also slightly improves said old behavior by producing an informative warning when this happens, instead of being silent like before.Tested locally, fixes the problem.
pinging @fcollonval, @blink1073