-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate settings schema #205
Conversation
d830df2
to
f89d3b2
Compare
f89d3b2
to
f4090eb
Compare
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
==========================================
- Coverage 77.97% 77.30% -0.67%
==========================================
Files 27 28 +1
Lines 1998 2058 +60
==========================================
+ Hits 1558 1591 +33
- Misses 440 467 +27
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I'll cut this release tomorrow |
Thank you! |
References
Fixes jupyterlab/jupyterlab#10414
Fixes jupyterlab/jupyterlab-translate#1
Closes jupyterlab/jupyterlab#10752
Code changes
The settings schemas are translated on the backend side before served to the frontend.
The code of the handlers was refactored.
The translation handler is now conditionned on the existence of settings configuration as they hold the locale source of thruth.
User changes
Settings translatable strings are displayed translated; in particular title and description in the setting editor.
Backward incompatible
N/A