Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update new_defaults dictionary instead of copy #194

Merged
merged 2 commits into from
Aug 3, 2021

Conversation

goanpeca
Copy link
Member

@goanpeca goanpeca commented Aug 3, 2021

Fixes a bug introduced on #188 which broke the overrides mechanism for defaults that ara dictionaries 😞

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2021

Codecov Report

Merging #194 (3fa2d0d) into master (13a0b8a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #194   +/-   ##
=======================================
  Coverage   78.63%   78.63%           
=======================================
  Files          27       27           
  Lines        2017     2017           
=======================================
  Hits         1586     1586           
  Misses        431      431           
Impacted Files Coverage Δ
jupyterlab_server/settings_handler.py 85.45% <100.00%> (ø)
jupyterlab_server/tests/test_settings_api.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13a0b8a...3fa2d0d. Read the comment docs.

@goanpeca goanpeca requested a review from blink1073 August 3, 2021 01:30
@goanpeca goanpeca self-assigned this Aug 3, 2021
@blink1073 blink1073 changed the title PR: Update den defaults dictionary instead of copy PR: Update new_defaults dictionary instead of copy Aug 3, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 added the bug label Aug 3, 2021
@blink1073 blink1073 added this to the 2.6 milestone Aug 3, 2021
@blink1073 blink1073 merged commit 1ac80fc into jupyterlab:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants