-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge overrides settings if values are dicts #188
Merge overrides settings if values are dicts #188
Conversation
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
==========================================
+ Coverage 78.55% 78.70% +0.14%
==========================================
Files 27 27
Lines 1996 2010 +14
==========================================
+ Hits 1568 1582 +14
Misses 428 428
Continue to review full report at Codecov.
|
The errors seem unrelated to the changes on this PR.
|
23c7a89
to
0f1f04e
Compare
57a1c25
to
570e2b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Fixes jupyterlab/jupyterlab#10010
When using overrides files, if a default value in a schema is a
dict
then it will update the default with thedict
provided by the overrides file.With
overrides.json
Before this change
The resulting system default settings would be:
After this change
The resulting system default settings would be: